Skip to content
Snippets Groups Projects

Include the new e/g monitoring into trig egamma monitoring package

include new e/g monitoring into trig egamma monitoring package and change somethings into the core of the trig e/g matching tool.

This is a new design of the trig e/g monitoring without the ASG. This design follow the same idea of the other groups.

Its not ready but I would like to share with the group to check if this design attend to the monitoring requirements.

Inheritance schema: AthMonitoring <- TrigEgammaMonitorBaseAlgorithm <- TrigEgammaMonitorAnalysisAlgorithm <- TrigEgammaMonitorTagAndProbeAlgorithm.

  • TrigEgammaMonitorBaseAlgorithm: Hold all e/g accessor methods, matching, tdt, pid tools;
  • TrigEgammaMonitorAnalysisAlgorithm: Hold all fill histograms methods (efficiency, resolution and distribution);
  • TrigEgammaMonitorTagAndProbeAlgorithm: select probe events and fill;

Ticker: ATR-19998

The make doc can be found here: /afs/cern.ch/user/j/jodafons/public/docs_triggerEgammaMonitoring

Ping: @fernando , @thrynova , @mverissi , @wsfreund , @tbold and @fwinkl

I hope this will work for us! :)

Edited by Joao Victor Da Fonseca Pinto

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Overall comment. This is rather complete implementation rather than a design draft. Again. Quite a chunk of code to review and understand. Good thing is that it is simpler what what we have seen before. That is good. I'll leave a few a suggestions though.

  • Tomasz Bold
  • Please resolve the open threads, then re-add the review-pending-level-1 label. Thanks!

    MLB (L1)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading