Skip to content
Snippets Groups Projects

Move from MuonIdHelperTool to MuonIdHelperSvc (8)

Merged Move from MuonIdHelperTool to MuonIdHelperSvc (8)
nkoehler/athena:muIdHelp8 into master
All threads resolved!
Merged Nicolas Koehler requested to merge nkoehler/athena:muIdHelp8 into master
All threads resolved!

Hi,

this MR uses MuonIdHelperSvc instead of MuonIdHelperTool in several packages.

Best, Nico

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tomasz Bold
  • Tomasz Bold
  • Tomasz Bold
  • Tomasz Bold
    Tomasz Bold @tbold ·
    Developer

    This is a very nice cleanup. The intent is clear and there is nothing sticking out. In contrary, cleanup of all this commented out code is just great. I have left a few, minor suggestions, feel free to close them for now as I assume there will be another iteration of this nice cleanup for instance to unify properties setting and they could be addressed then. Please flip labels back to L2 once you decide.

  • Tomasz Bold added review-user-action-required label and removed review-pending-level-2 label

    added review-user-action-required label and removed review-pending-level-2 label

  • Nicolas Koehler added 164 commits

    added 164 commits

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 6 packages:

    • InnerDetector/InDetExample/InDetRecExample
    • MuonSpectrometer/MuonCablings/MuonRPC_Cabling
    • MuonSpectrometer/MuonCalib/NSWCalib/NSWCalibTools
    • MuonSpectrometer/MuonCnv/MuonByteStream
    • MuonSpectrometer/MuonCnv/MuonCSC_CnvTools
    • MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools

    Adding @goetz ,@rosati ,@wleight ,@sroe ,@nkoehler as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Nicolas Koehler resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 1df11bc0)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13193]

  • Peter Berta added review-pending-level-2 label and removed review-pending-level-1 label

    added review-pending-level-2 label and removed review-pending-level-1 label

  • Pavol Strizenec
    Pavol Strizenec @pavol ·
    Developer

    Looks fine now, approving.

    Pavol [as L2 MR shifter]

  • Pavol Strizenec added review-approved label and removed review-pending-level-2 label

    added review-approved label and removed review-pending-level-2 label

  • Vakhtang Tsulaia merged

    merged

  • Vakhtang Tsulaia mentioned in commit c01504f6

    mentioned in commit c01504f6

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply