Make executeVertexFinder() const in TauVertexFinder class
Prepare class TauVertexFinder to be reentrant. Virtual non const method executeVertexFinder calls non virtual const method executeVertexFinder.
Merge request reports
Activity
added master no-domain review-pending-level-1 labels
CI Result SUCCESS (hash 3086b337)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13147]added review-user-action-required label and removed review-pending-level-1 label
added 1 commit
- eaecaf83 - Make executeVertexFinder() const in TauVertexFinder
added Reconstruction Tau review-pending-level-1 labels and removed review-user-action-required label
CI Result FAILURE (hash eaecaf83)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13224]The changes look just right. One thing, that realy does not belong to this MR stikes though. Namely the use of float to exchange information from/to
getPV_TJVA
andgetJetVertexFraction
. Would it be ok to replace them with doubles? Tagging @xiaozhon for this.- Resolved by Xiaozhong Huang
Hi @tbold
Either float or double look good to me. When saving the vertex fraction into EDM, they will all be cast to float. I was wondering whether we gain something by replacing them with double.
CI Result SUCCESS (hash eaecaf83)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13232]added review-approved label and removed review-pending-level-1 label
mentioned in commit 1481e611
added sweep:ignore label