Skip to content
Snippets Groups Projects

Respect useSctDCS when enabling cond tools

Merged Respect useSctDCS when enabling cond tools
tbold/athena:fix-new-jo-id-config into master
All threads resolved!
Merged Tomasz Bold requested to merge tbold/athena:fix-new-jo-id-config into master
All threads resolved!

Even when running on data, when instructed the DCS based condition tools are not enabled when the respective InDet flag is set to False. Fixes: https://its.cern.ch/jira/browse/ATR-21280

Credits for investigative work goes to @mvozak

In addition, there was a mistake/typo in SCT_TdaqEnabledToolCfg it was configuring SCT_CablingTool whereas (according to the provided example: https://gitlab.cern.ch/atlas/athena/blob/master/InnerDetector/InDetConditions/SCT_ConditionsTools/python/SCT_TdaqEnabledToolSetup.py it should be configuring SCT_TdaqEnabledTool. Tagging @goetz and @sroe - please retag experts.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 82278670)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 8, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13643]

  • Tomasz Bold
    Tomasz Bold @tbold
    Author Developer

    These errors are not related. Should I restart or it makes no sense?

  • Tomasz Bold added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    This merge request affects 2 packages:

    • InnerDetector/InDetConfig
    • Trigger/TrigTools/TrigInDetConfig

    Adding @goetz ,@sroe ,@mvozak as watchers

  • ATLAS Robot added Trigger label

    added Trigger label

  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash f252f591)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13657]

  • Tomasz Bold
    Tomasz Bold @tbold
    Author Developer

    The error is known and should be fixed with: !32700 (merged)

  • Baida Achkar
    Baida Achkar @bachkar

    since the error is fixed, I approve the MR. BA (L1)

  • Baida Achkar added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Baida Achkar approved this merge request

    approved this merge request

  • Walter Lampl resolved all threads

    resolved all threads

  • Walter Lampl merged

    merged

  • Walter Lampl mentioned in commit bb3c6428

    mentioned in commit bb3c6428

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

  • Susumu Oda mentioned in commit 3e80f7b2

    mentioned in commit 3e80f7b2

    • Please register or sign in to reply