xAODPrimitives Python Helper, master branch (2020.05.27.)

This is meant to fix the issue(s) described in ATR-21477.

As @fwinkl reported, unfortunately the xAODCoreRflxDict -> xAODCoreDict name change introduced with !33176 (merged) caused a number of failures in the last nightly.

Instead of just changing the names of the dictionary libraries loaded in our Python configuration explicitly, I decided to do something better. I introduced some python code into xAODPrimitives that could be used to provide access to the enumerations defined in the xAOD::Iso namespace. Instead of clients loading libraries explicitly left and right. (As it turns out, xAODCoreRflxDict was always loaded to get access to those enumerations. Which by itself is a weird thing...)

While making changes in the clients so that they would use the new xAODPrimitives.xAODIso module, I also made some other changes.

• Reconstruction/egamma/egammaTools/python/EMShowerBuilder.py didn't apparently need any of these enumerations by now, the code could just be removed;
• PhysicsAnalysis/SUSYPhys/LongLivedParticleDPDMaker/python/HNLFlags.py:
  • Made sure that the module could be loaded by itself. (Previously it couldn't be, as I found in my testing.)
  • Removed the _v1 postfixes from the xAOD::Muon type names, as with the recently introduced typedefs ROOT.xAOD.Muon is now a known type.

These cover every single place where xAODCoreRflxDict was mentioned in our code. So to speed things up, I'd rather want to avoid running the MR with full-unit-tests. But if you think Frank that we should do full unit tests, then we'll do that...

added bugfix urgent labels

This merge request affects 8 packages:

• Event/xAOD/xAODPrimitives
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMuons
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkSUSY
• PhysicsAnalysis/SUSYPhys/LongLivedParticleDPDMaker
• Reconstruction/RecoAlgs/IsolationAlgs
• Reconstruction/RecoTools/IsolationTool
• Reconstruction/egamma/egammaTools
• Trigger/TrigAlgorithms/TrigEgammaRec

Adding @hoide ,@goetz ,@ctreado ,@jdandoy ,@cohm ,@crizzi ,@szambito ,@kdipetri ,@oabouzei ,@akraszna ,@ykeisuke ,@jmontejo ,@alopezso ,@leejr as watchers

added Analysis Derivation EDM Egamma Reconstruction Trigger master review-pending-level-1 labels

CI Result SUCCESS (hash dc33e688)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14625]

The changes look ok. Adding review-approved label.

L1 shifter

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit c2ba0cff

added sweep:ignore label