using regsel tool in CscRdoToCscPrepData, RpcRdoToRpcPrepData, TgcRdoToTgcPrepData
RegSelSvc needs to be replaced by RegSelTool for the MT migration.
I request this to finish the MDT Cabling Svc MT migration.
Related MR: !31761 (merged) !33395 (merged) !33703 (merged) !33956 (merged)
Merge request reports
Activity
added MuonSpectrometer master review-pending-level-1 labels
CI Result FAILURE (hash 7739c5e8)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15380]added review-user-action-required label and removed review-pending-level-1 label
added 524 commits
-
7739c5e8...dce8f066 - 523 commits from branch
atlas:master
- f70656df - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into master-RegSelToolInMS-v03
-
7739c5e8...dce8f066 - 523 commits from branch
added 257 commits
-
f70656df...0477337e - 255 commits from branch
atlas:master
- 78d278eb - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into master-RegSelToolInMS-v03
- 9846f7a7 - configure RegSelTool for CSC, RPC, TGC to be used in newJO trigger test
-
f70656df...0477337e - 255 commits from branch
added Geometry Trigger review-pending-level-1 labels and removed review-user-action-required label
CI Result FAILURE (hash 9846f7a7)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15881]mentioned in merge request !33889 (merged)
Hi, for some reason, I was not flagged as a watcher on this merge request, despite it changing the RegionSelector configuration.
There is another merge request which also changes the RegSelTool configuration code ...
and here I requested that we change to use the newer, clearer naming convention, so I make the same request here, to eg move to use
regSelTool_CSC_Cfg
and so on for the tools, rather than cram together a large number of letters, although these configuration routines, are in fact already created in the newer request.
Since this other merge request changes the way the configurations are coded, I would like to also request that this request makes use of those changes there once they been merged.
To summarise that change, since there are a lot of tools from each subdetector, it was felt preferable to have some common configuration such that the individual subdetector tools only need to differ in the actual code that was different, and not repeat the common parts of the routines. This might seem like a small change, but with a large number of essentially identical boiler plated configuration code, making any future changes needed would need to be repeated for all the tools and would become a chore, and would be very prone to small errors creeping in.
Cheers Mark
Edited by Mark Suttonremoved review-pending-level-1 label