Update MuonSegmentRegionRecoveryTool to use new region selector tools
Migrating the MuonSegmentRegionRecoveryTool to use the new region selector tools instead of the region selector service:
- Extend the new JO configuration for the region selector tools to include the rest of the muon technologies
- Update the segment region recovery tool to use the region selector tools instead of the old service
- Update the configuration for the segment region recovery (both old and new style JOs)
- We were always configuring the MuonSegmentRegionRecoveryTool due to the 'getPublicTool' call in MooreTools.py. This caused some issues with scheduling the region selector cond alg out of place in the legacy trigger tests. In the end this 'getPublicTool' call is not needed, since the tools are all configured in the relevent places, so have removed it.
Fixes ATLASRECTS-5377.
Merge request reports
Activity
This merge request affects 5 packages:
- DetectorDescription/RegionSelector
- MuonSpectrometer/MuonConfig
- MuonSpectrometer/MuonReconstruction/MuonRecExample
- MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools
- Reconstruction/MuonIdentification/MuonCombinedRecExample
Adding @sutt ,@goetz ,@rosati ,@wleight ,@nkoehler ,@rbianchi as watchers
Hi Many thanks Savanna, would it be possible to use the naming convention "regSelTool_MDT_Cfg()" for instance, for more consistency with the other standard configuration ?
Also for the Cfg() functions themselves, would it be possible to replace most of the internal code with a function, say _regSelToolCfg(), and then simply have the specific Cfg() functions call this ? This way it would reduce the duplication in the code and would be tidier in case we need to add additional functions for the other subsystems.
Cheers Mark
added 1 commit
- 93b46351 - Reduce duplicate code for RegSelTools config, and update names tool config function names
❎ CI Result FAILURE (hash 0c5d20bf)Athena AthSimulation AnalysisBase AthGeneration externals ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ make ✅ ✅ ✅ ✅ required tests ⭕ ✅ ✅ ✅ optional tests ✅ ✅ ✅ ✅ Full details available on this CI monitor view
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15779]This merge request affects 5 packages:
- DetectorDescription/RegionSelector
- MuonSpectrometer/MuonConfig
- MuonSpectrometer/MuonReconstruction/MuonRecExample
- MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools
- Reconstruction/MuonIdentification/MuonCombinedRecExample
Adding @sutt ,@goetz ,@rosati ,@wleight ,@nkoehler ,@rbianchi as watchers
added 1 commit
- 2dfeb3e7 - fix typo when configuring sTGC region selector tool
This merge request affects 5 packages:
- DetectorDescription/RegionSelector
- MuonSpectrometer/MuonConfig
- MuonSpectrometer/MuonReconstruction/MuonRecExample
- MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools
- Reconstruction/MuonIdentification/MuonCombinedRecExample
Adding @sutt ,@goetz ,@rosati ,@wleight ,@nkoehler ,@rbianchi as watchers
❎ CI Result FAILURE (hash 93b46351)Athena AthSimulation AnalysisBase AthGeneration externals ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ make ✅ ✅ ✅ ✅ required tests ⭕ ✅ ✅ ✅ optional tests ✅ ✅ ✅ ✅ Full details available on this CI monitor view
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15793]✅ CI Result SUCCESS (hash 2dfeb3e7)Athena AthSimulation AnalysisBase AthGeneration externals ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ make ✅ ✅ ✅ ✅ required tests ✅ ✅ ✅ ✅ optional tests ✅ ✅ ✅ ✅ Full details available on this CI monitor view
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15795]added urgent label
mentioned in merge request !33889 (merged)
mentioned in merge request !33663 (merged)