Skip to content
Snippets Groups Projects

PyJobTransformsCore: Enable flake8 checking and fix code

Merged Frank Winklmeier requested to merge fwinkl/athena:pytrf_py3 into master

Make code flake8/Py3 compliant. Delete unused CVSutil and CastorPreStager module.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hi @fwinkl, you accidentally commited a commented-out line. Otherwise it looks OK.

    Tadej (L2)

  • Frank Winklmeier resolved all threads

    resolved all threads

  • added 1 commit

    • f8f14b02 - PyJobTransformsCore: Enable flake8 checking and fix code

    Compare with previous version

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 104K in file Tools/PyJobTransformsCore/python/trfutil.py

    :pencil: 116K in file Tools/PyJobTransformsCore/python/trf.py

  • This merge request affects 2 packages:

    • Reconstruction/RecJobTransforms
    • Tools/PyJobTransformsCore

    Adding @goetz as watcher

  • :white_check_mark: CI Result SUCCESS (hash f8f14b02)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16289]

  • added review-approved label and removed review-pending-level-1 label

  • All OK now :)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading