TrigEFMissingET: cmake config cleanup and flake8
Remove the unused TrigEFMissingETLib
library and compile all source
files directly into the component library. Enable flake8 and make code
compliant.
Merge request reports
Activity
added JetEtmiss Trigger master review-pending-level-1 labels
CI Result FAILURE (hash 78966734)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17272]added 1 commit
- 1930abbc - TrigEFMissingET: cmake config cleanup and flake8
CI Result SUCCESS (hash 1930abbc)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17297]The library was originally deliberate - I wanted the
pufit
code to be externally accessible, however, it does seem like we'd be a long way off this actually being used inmaster
so I'm OK with letting this through, and remaking the library when it's actually needed. Similarly the explicit listing of all the source files was deliberate as I don't really like the addition of globbing intocmake
, however I accept that I'm in the minority here...added review-approved label and removed review-pending-level-1 label
mentioned in commit 1056eafd
added sweep:ignore label