DictLoaderSvc: Make load_type thread-safe

Switch to using RootType::ByNameNoQuiet in load_type in order to make this method thread-safe. In case of a missing dictionary, ROOT would now print an error message, which we do not expect to happen.

This makes TrigSerializeTP thread-safe (ATR-21733).

Would like explicit approval from @ssnyder or @mnowak.

This merge request affects 3 packages:

• Control/AthenaKernel
• Control/AthenaServices
• Trigger/TrigDataAccess/TrigSerializeTP

Adding @ssnyder as watcher

added Core Trigger master review-pending-level-1 labels

I think this should be ok.

I'd suggest running this with full unit tests, though.

added full-unit-tests label

Jenkins please retry a build

resolved all threads

Jenkins please retry a build

This merge request affects 3 packages:

• Control/AthenaKernel
• Control/AthenaServices
• Trigger/TrigDataAccess/TrigSerializeTP

Adding @ssnyder as watcher

CI Result FAILURE (hash bf570af3)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17447]

Same test failures as in the nightly.

Jenkins please retry a build

This merge request affects 3 packages:

• Control/AthenaKernel
• Control/AthenaServices
• Trigger/TrigDataAccess/TrigSerializeTP

Adding @ssnyder as watcher

CI Result FAILURE (hash bf570af3)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17617]

As jenkins report seems inconsistent, I'll retry

Jenkins please retry a build

This merge request affects 3 packages:

• Control/AthenaKernel
• Control/AthenaServices
• Trigger/TrigDataAccess/TrigSerializeTP

Adding @ssnyder as watcher

CI Result FAILURE (hash bf570af3)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17719]

Unrelated unit test failures (because this was run with full-unit-tests). Failures are the same as in the nightly build.

Looks OK, approving.

Tadej (L2)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 59cd51cb

added sweep:ignore label