Remove boilerplate code from BTagging and FlavorTagDiscriminants

This is part 1 of a bit of cleanup in b-tagging. I'd like to make sure that the inputs to DL1 are properly defined, but first I wanted to reduce repetition in the code slightly.

This removes about 200 lines of boiler plate code: replaces a bunch of similar function calls with one call that returns the same information.

Jenkins please retry a build

This merge request affects 2 packages:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants
• PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging

Adding @dguest ,@cvarni ,@guirriec ,@lidiaz as watchers

added Analysis BTagging Derivation JetEtmiss master labels

CI Result FAILURE (hash ffa1ffb0)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17778]

changed the description

added 224 commits

• ffa1ffb0...e8df3bb2 - 223 commits from branch atlas:master
• 1611afda - Remove 200 lines of boilerplate code

Compare with previous version

Jenkins please retry a build

This merge request affects 2 packages:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants
• PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging

Adding @dguest ,@cvarni ,@guirriec ,@lidiaz as watchers

I'm curious if @cvarni or @guirriec have any ideas here: I'm not sure how these changes are doing anything different, but for some reason putting the ReadDecorHandles in a vector and looping over them is causing a segfault. From what I can tell the segfault happens after every one of the handles has been initialized and the algorithm returns.

Maybe there's some other more recommended pattern to follow here?

added 1 commit

• a435b2ff - Use unique_ptr<T> rather than T in write handle vector

Compare with previous version

resolved all threads

unmarked as a Work In Progress

changed title from WIP: btagging boilerplate cleanup to Remove boilerplate code from BTagging and FlavorTagDiscriminants

This merge request affects 3 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag
• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants
• PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging

Adding @nishu ,@rcreager ,@sanmay ,@guirriec ,@dguest ,@cvarni ,@bdong ,@lidiaz as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash 1611afda)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17855]

CI Result SUCCESS (hash a435b2ff)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17864]

The changes are fine and the CI issue is unrelated. Approving.

Jason (L1)

added review-approved label and removed review-pending-level-1 label

resolved all threads