the usage of NSW in TrigL2MuonSA

TrigL2MuonSA is updated to use the NSW in muFast step of HLT Muon. The new functionality is turned on/off automatically based on sample geometry. This MR should not affect central trigger validations.

Tests for Run3 geometries are not completed, but the issues seem to be outside TrigL2MuonSA package. Some JIRA tickets are open for the issues: ATR-21825, ATR-21829 and ATR-21830.

The update of EDM for L2StandAloneMuon was already merged by another MR: !35089 (merged) The interface of L2StandAloneMuon is updated by this MR.

tagging @nakahama and @sshaw

added Trigger master labels

added 97 commits

• 4df187f8...7e7fea0e - 95 commits from branch atlas:master
• b2b65f53 - Merge remote-tracking branch 'upstream/master' into NSW_woEDM
• 5a3f9c0b - clean up

Compare with previous version

added 284 commits

• 5a3f9c0b...346b0de6 - 281 commits from branch atlas:master
• ca6ca3ec - disable RoI based data access
• f8352062 - introduce region selector tool
• 4b2bb067 - Merge remote-tracking branch 'upstream/master' into NSW_woEDM

Compare with previous version

added 140 commits

• 4b2bb067...cd010919 - 138 commits from branch atlas:master
• bdc36eef - Merge remote-tracking branch 'upstream/master' into NSW_woEDM
• d7845ce4 - Merge remote-tracking branch 'upstream/master' into NSW_woEDM

Compare with previous version

added 29 commits

• d7845ce4...907fd5cf - 28 commits from branch atlas:master
• f7e4147b - Merge remote-tracking branch 'upstream/master' into NSW_woEDM

Compare with previous version

resolved all threads

Hi @sshaw and @nakahama,

The issues on Run3 samples (reported on ATR-21825, ATR-21829 and ATR-21830) were solved or avoided. Also we solved all threads on this MR. So can we remove "WIP" from this MR?

Best, Yohei

Hi Yohei,

sounds good to me.

Cheers,

Savanna

unmarked as a Work In Progress

changed the description

This merge request affects 3 packages:

• Event/xAOD/xAODTrigMuon
• Trigger/TrigAlgorithms/TrigL2MuonSA
• Trigger/TriggerCommon/TriggerMenuMT

Adding @akraszna ,@bernius as watchers

added EDM TriggerMenu review-pending-level-1 labels

CI Result FAILURE (hash f7e4147b)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19444]

Hi for the NSW implementation in the RegSelTools, there was some question about what should actually be stored to be most useful. At the moment we use the detector element context, but the module context was also available ...

  /// do we want the module context ...
  ///  const IdContext ModuleContext = helper->module_context();
  
  /// or the detector element context ? Keep them both untill we are sure 
  const IdContext ModuleContext = helper->detectorElement_context();

so we should use whichever is the most useful to people. So if this should be changed, please let me know and I will make the change in a separate Merge Request.

Cheers Mark

Looks like they are unresolved conversations. Going to remove the review label.

added review-user-action-required label and removed review-pending-level-1 label

Hi just to clarify, my last point was only a point or relevance that I might need to follow up myself in a different merge request, it not was a request for any action needed for this merge request

Cheers Mark

Thanks, Mark. We will keep in mind that this could change.

@Yohei, it looks like the newJO configuration also needs some updating to handle/ignore the NSW (and the compiler warning is also from L2MuonSA).

Cheers,

Savanna

added 772 commits

• f7e4147b...1f7eae6f - 769 commits from branch atlas:master
• 6be8e87c - Merge remote-tracking branch 'upstream/master' into NSW_woEDM
• 8facb038 - Merge remote-tracking branch 'upstream/master' into NSW_woEDM
• 1df05390 - introduce sTGC/MM DataPreparator into newJO

Compare with previous version

This merge request affects 3 packages:

• Event/xAOD/xAODTrigMuon
• Trigger/TrigAlgorithms/TrigL2MuonSA
• Trigger/TriggerCommon/TriggerMenuMT

Adding @akraszna ,@bernius as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 1df05390)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19484]

resolved all threads

Tests pass, but changes are extensive, with several new (non-trivial) files. Passing to L2 for review. (L1 shifter)

added review-pending-level-2 label and removed review-pending-level-1 label

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit ee01a1c1

added sweep:ignore label