Skip to content
Snippets Groups Projects

Muon RDO decoding AthReentrantAlg changes

Merged Muon RDO decoding AthReentrantAlg changes
iconnell/athena:iac_muoncnv_rentrant into master
Merged Ian Allan Connelly requested to merge iconnell/athena:iac_muoncnv_rentrant into master

This MR is to collect together changes to the MuonBytestream classes to make them AthReentrantAlgorithms. This requires adding new EventContext functions and allowing non-MT code to still use the same function calls. Some changes are driven by requiring functions to now be const.

Edited by Ian Allan Connelly

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ian Allan Connelly added 1 commit

    added 1 commit

    Compare with previous version

  • Ian Allan Connelly added 1 commit

    added 1 commit

    Compare with previous version

  • Ian Allan Connelly changed the description

    changed the description

  • Ian Allan Connelly unmarked as a Work In Progress

    unmarked as a Work In Progress

  • I
    Ian Allan Connelly @iconnell ·
    Author

    I have removed WIP for CSC and MDT changes as my own tests have not shown any issues (FrozenT0 and also other trigger tests) and I want to make sure nothing unexpected is flagged in CI. I will reapply WIP while I work on the other changes.

    Edited by Ian Allan Connelly
  • Ian Allan Connelly marked as a Work In Progress

    marked as a Work In Progress

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • MuonSpectrometer/MuonCnv/MuonByteStream
    • MuonSpectrometer/MuonCnv/MuonCSC_CnvTools
    • MuonSpectrometer/MuonCnv/MuonCnvToolInterfaces
    • MuonSpectrometer/MuonCnv/MuonMDT_CnvTools

    Adding @rosati ,@wleight ,@nkoehler as watchers

  • ATLAS Robot added MuonSpectrometer master review-pending-level-1 labels

    added MuonSpectrometer master review-pending-level-1 labels

  • Ana Maria Rodriguez Vera added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash a9b135d9)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 2
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18535]

  • I
    Ian Allan Connelly @iconnell ·
    Author

    Looks like I need to have a look into these two tests which fail on CSC ROI decoding. Not sure why at the moment that these fail.

  • Ian Allan Connelly added 1 commit

    added 1 commit

    • 2e6ae70c - First pass on RPC updates for AthReentrant

    Compare with previous version

  • Ian Allan Connelly unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Ian Allan Connelly marked as a Work In Progress

    marked as a Work In Progress

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 5 packages:

    • MuonSpectrometer/MuonCnv/MuonByteStream
    • MuonSpectrometer/MuonCnv/MuonCSC_CnvTools
    • MuonSpectrometer/MuonCnv/MuonCnvToolInterfaces
    • MuonSpectrometer/MuonCnv/MuonMDT_CnvTools
    • MuonSpectrometer/MuonCnv/MuonRPC_CnvTools

    Adding @rosati ,@wleight ,@nkoehler as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Johannes Junggeburth removed review-pending-level-1 label

    removed review-pending-level-1 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 2e6ae70c)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18603]

  • I
    Ian Allan Connelly @iconnell ·
    Author

    Trigger_athena_MC-test

    • test_trigAna_RDOtoRDOTrig_mt1_build.py
    -TrigSignatureMoniMT                            0    INFO The L1 seed to multi-item-seeded chain HLT_noalg_L1Standby could not be completely resolved. This is currently OK. Exception from menu access: L1Item L1_2EM13VH does not exist in the menu
-TrigSignatureMoniMT                            0    INFO The L1 seed to multi-item-seeded chain HLT_noalg_L1Calo could not be completely resolved. This is currently OK. Exception from menu access: L1Item L1_2EM13VH does not exist in the menu
+TrigSignatureMoniMT                            0    INFO The L1 seed to multi-item-seeded chain HLT_noalg_L1Standby could not be completely resolved. This is currently OK. Exception from menu access: L1Item L1_2EM15VHI does not exist in the menu
+TrigSignatureMoniMT                            0    INFO The L1 seed to multi-item-seeded chain HLT_noalg_L1Calo could not be completely resolved. This is currently OK. Exception from menu access: L1Item L1_2EM15VHI does not exist in the menu

    This seems to me like something was adjusted elsewhere in the code such that L1_2EM13VH was replaced with L1_2EM15VHI so I will update the reference file for this

    Edited by Ian Allan Connelly
  • I
    Ian Allan Connelly @iconnell ·
    Author

    Trigger_athena_Data-test

    • test_trig_data_v1Dev_build.py
    Found messages in athena.log (7):
CscRawDataProvider_MURoIs                  1   0   ERROR RoI seeded BS conversion into RDOs failed
CscRawDataProvider_MURoIs                  9   0   ERROR RoI seeded BS conversion into RDOs failed
CscRawDataProvider_MURoIs                 15   0   ERROR RoI seeded BS conversion into RDOs failed
CscRawDataProvider_MURoIs                 15   0   ERROR RoI seeded BS conversion into RDOs failed
CscRawDataProvider_MURoIs                 19   0   ERROR RoI seeded BS conversion into RDOs failed
CscRawDataProvider_MURoIs                 19   0   ERROR RoI seeded BS conversion into RDOs failed
CscRawDataProvider_MURoIs                 19   0   ERROR RoI seeded BS conversion into RDOs failed

    This is unexpected (I think), so I will investigate further. There is also a discrepancy with the reference file which is identical to the above which I will address.

    • test_trig_data_v1Cosmic_build.py

    There is a "step failure" in the CI which I am not sure about the origin. There are hundred of lines with the format

    ToolSvc.AtlasExtrapolator.sysFinalize          0   FATAL  Exception with tag=Gaudi::StateMachine::ChangeState is caught
ToolSvc.AtlasExtrapolator.sysFinalize          0   ERROR Gaudi::StateMachine::ChangeState 	 Invalid transition 'FINALIZE' from state 'RUNNING'	 StatusCode=FAILURE

    which looks like its for all tools used. I cannot see what causes this error at all in the log but I can try running the test locally.

  • I
    Ian Allan Connelly @iconnell ·
    Author

    Trigger_athenaHLT-test

    • test_trigP1_v1Dev_decodeBS_build.py
    Found messages in athena.log (14):
CscRawDataProvider_MURoIs                 16   0   ERROR RoI seeded BS conversion into RDOs failed [360026,629096759,t:1536151928.814699960,l:151,b:2220]
CscRawDataProvider_MURoIs                 48   0   ERROR RoI seeded BS conversion into RDOs failed [360026,629186765,t:1536151929.856277135,l:151,b:2430]
CscRawDataProvider_MURoIs                 50   0   ERROR RoI seeded BS conversion into RDOs failed [360026,629151184,t:1536151929.445275770,l:151,b:2726]
CscRawDataProvider_MURoIs                 72   0   ERROR RoI seeded BS conversion into RDOs failed [360026,629180549,t:1536151929.782391310,l:151,b:2846]
CscRawDataProvider_MURoIs                 86   0   ERROR RoI seeded BS conversion into RDOs failed [360026,629198402,t:1536151929.992508075,l:151,b:2378]
CscRawDataProvider_MURoIs                 89   0   ERROR RoI seeded BS conversion into RDOs failed [360026,629037006,t:1536151928.117015570,l:151,b:2891]
CscRawDataProvider_MURoIs                 89   0   ERROR RoI seeded BS conversion into RDOs failed [360026,629037006,t:1536151928.117015570,l:151,b:2891]
2020-Aug-12 19:33:21,786 ERROR [ at CscRawDataProvider_MURoIs:-98212855] CscRawDataProvider_MURoIs: RoI seeded BS conversion into RDOs failed [360026,629096759,t:1536151928.814699960,l:151,b:2220]
2020-Aug-12 19:33:35,711 ERROR [ at CscRawDataProvider_MURoIs:-98212855] CscRawDataProvider_MURoIs: RoI seeded BS conversion into RDOs failed [360026,629186765,t:1536151929.856277135,l:151,b:2430]
2020-Aug-12 19:33:36,629 ERROR [ at CscRawDataProvider_MURoIs:-98212855] CscRawDataProvider_MURoIs: RoI seeded BS conversion into RDOs failed [360026,629151184,t:1536151929.445275770,l:151,b:2726]
2020-Aug-12 19:33:42,718 ERROR [ at CscRawDataProvider_MURoIs:-98212855] CscRawDataProvider_MURoIs: RoI seeded BS conversion into RDOs failed [360026,629180549,t:1536151929.782391310,l:151,b:2846]
2020-Aug-12 19:33:56,646 ERROR [ at CscRawDataProvider_MURoIs:-98212855] CscRawDataProvider_MURoIs: RoI seeded BS conversion into RDOs failed [360026,629198402,t:1536151929.992508075,l:151,b:2378]
2020-Aug-12 19:33:57,657 ERROR [ at CscRawDataProvider_MURoIs:-98212855] CscRawDataProvider_MURoIs: RoI seeded BS conversion into RDOs failed [360026,629037006,t:1536151928.117015570,l:151,b:2891]
2020-Aug-12 19:33:57,658 ERROR [ at CscRawDataProvider_MURoIs:-98212855] CscRawDataProvider_MURoIs: RoI seeded BS conversion into RDOs failed [360026,629037006,t:1536151928.117015570,l:151,b:2891]
FAILURE : error/fatal found in athena.log

    This looks somewhat linked to the CSC RoI error in the data test. Again not sure why these appear but I will try to investigate.

    • test_trigP1_v1PhysP1_build.py
    Found messages in athena.log (14):
CscRawDataProvider_MURoIs                 16   0   ERROR RoI seeded BS conversion into RDOs failed [360026,629096759,t:1536151928.814699960,l:151,b:2220]
CscRawDataProvider_MURoIs                 48   0   ERROR RoI seeded BS conversion into RDOs failed [360026,629186765,t:1536151929.856277135,l:151,b:2430]
CscRawDataProvider_MURoIs                 50   0   ERROR RoI seeded BS conversion into RDOs failed [360026,629151184,t:1536151929.445275770,l:151,b:2726]
CscRawDataProvider_MURoIs                 72   0   ERROR RoI seeded BS conversion into RDOs failed [360026,629180549,t:1536151929.782391310,l:151,b:2846]
CscRawDataProvider_MURoIs                 86   0   ERROR RoI seeded BS conversion into RDOs failed [360026,629198402,t:1536151929.992508075,l:151,b:2378]
CscRawDataProvider_MURoIs                 89   0   ERROR RoI seeded BS conversion into RDOs failed [360026,629037006,t:1536151928.117015570,l:151,b:2891]
CscRawDataProvider_MURoIs                 89   0   ERROR RoI seeded BS conversion into RDOs failed [360026,629037006,t:1536151928.117015570,l:151,b:2891]
2020-Aug-12 19:38:19,882 ERROR [ at CscRawDataProvider_MURoIs:-98212855] CscRawDataProvider_MURoIs: RoI seeded BS conversion into RDOs failed [360026,629096759,t:1536151928.814699960,l:151,b:2220]
2020-Aug-12 19:38:32,193 ERROR [ at CscRawDataProvider_MURoIs:-98212855] CscRawDataProvider_MURoIs: RoI seeded BS conversion into RDOs failed [360026,629186765,t:1536151929.856277135,l:151,b:2430]
2020-Aug-12 19:38:32,761 ERROR [ at CscRawDataProvider_MURoIs:-98212855] CscRawDataProvider_MURoIs: RoI seeded BS conversion into RDOs failed [360026,629151184,t:1536151929.445275770,l:151,b:2726]
2020-Aug-12 19:38:38,163 ERROR [ at CscRawDataProvider_MURoIs:-98212855] CscRawDataProvider_MURoIs: RoI seeded BS conversion into RDOs failed [360026,629180549,t:1536151929.782391310,l:151,b:2846]
2020-Aug-12 19:38:51,264 ERROR [ at CscRawDataProvider_MURoIs:-98212855] CscRawDataProvider_MURoIs: RoI seeded BS conversion into RDOs failed [360026,629198402,t:1536151929.992508075,l:151,b:2378]
2020-Aug-12 19:38:52,097 ERROR [ at CscRawDataProvider_MURoIs:-98212855] CscRawDataProvider_MURoIs: RoI seeded BS conversion into RDOs failed [360026,629037006,t:1536151928.117015570,l:151,b:2891]
2020-Aug-12 19:38:52,102 ERROR [ at CscRawDataProvider_MURoIs:-98212855] CscRawDataProvider_MURoIs: RoI seeded BS conversion into RDOs failed [360026,629037006,t:1536151928.117015570,l:151,b:2891]
FAILURE : error/fatal found in athena.log

    Appears identical/same as the above error.

  • Ian Allan Connelly added 2 commits

    added 2 commits

    • 6af0d18b - Updating reference file for ctest
    • e671ddb8 - Updating reference file for ctest (data)

    Compare with previous version

  • Ian Allan Connelly added 1 commit

    added 1 commit

    • 7791ae7c - Fixing issue in MT CSC converter

    Compare with previous version

  • I
    Ian Allan Connelly @iconnell ·
    Author

    I believe I've understood these errors. One of my convert functions was passing to a method which was not implemented, owing to the fact that the non-EventContext function ignored one of the arguments. This has been rectified and will be tested in the CI now.

  • Ian Allan Connelly unmarked as a Work In Progress

    unmarked as a Work In Progress

  • I
    Ian Allan Connelly @iconnell ·
    Author

    Jenkins please retry a build

  • Ian Allan Connelly added 1289 commits

    added 1289 commits

    • 7791ae7c...dcd868a4 - 1288 commits from branch atlas:master
    • e5202a2d - Pulling in master, resolving refernce file conflic by taking remote

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 5 packages:

    • MuonSpectrometer/MuonCnv/MuonByteStream
    • MuonSpectrometer/MuonCnv/MuonCSC_CnvTools
    • MuonSpectrometer/MuonCnv/MuonCnvToolInterfaces
    • MuonSpectrometer/MuonCnv/MuonMDT_CnvTools
    • MuonSpectrometer/MuonCnv/MuonRPC_CnvTools

    Adding @rosati ,@wleight ,@nkoehler as watchers

  • ATLAS Robot added review-pending-level-1 label

    added review-pending-level-1 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash e5202a2d)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19324]

  • M
    Mike Hance @mhance ·
    Developer

    I think there are still warnings to address. (L1)

  • Mike Hance added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • I
    Ian Allan Connelly @iconnell ·
    Author

    Yes this is my next step, I am pleased the tests are happy. The warning relates to the TGC code which I have not yet implemented the new functions for.

  • Stewart Martin-Haugh
    Stewart Martin-Haugh @smh ·
    Developer

    Just to make the link, this is for ATR-21469

  • Ian Allan Connelly added 2 commits

    added 2 commits

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 6 packages:

    • MuonSpectrometer/MuonCnv/MuonByteStream
    • MuonSpectrometer/MuonCnv/MuonCSC_CnvTools
    • MuonSpectrometer/MuonCnv/MuonCnvToolInterfaces
    • MuonSpectrometer/MuonCnv/MuonMDT_CnvTools
    • MuonSpectrometer/MuonCnv/MuonRPC_CnvTools
    • MuonSpectrometer/MuonCnv/MuonTGC_CnvTools

    Adding @rosati ,@wleight ,@nkoehler as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash a7e9219d)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19625]

  • Ben Bruers added review-pending-level-2 label and removed review-pending-level-1 label

    added review-pending-level-2 label and removed review-pending-level-1 label

  • I
    Ian Allan Connelly @iconnell ·
    Author

    Hi all

    The tests here and from my side all seem to be functional. I attach the last frozen T0 test : RunTier0Tests.log. This passed successfully, the only unusual print out was :

    08-31 12:41 WARNING  Test log file run_q221/log.HITtoRDO has 1 less warnings than the reference log file /home/ppe/i/iconnell/projects/MuonTriggerAthenaMT/Test/200827_r24/RunTier0Tests/clean_run_q221_239cee64-217f-499e-8e65-c257cd041236/log.HITtoRDO
08-31 12:41 WARNING  The reduction of unnecessary WARNINGs is much appreciated. Is it expected?
08-31 12:41 WARNING  The following warning messages have been removed:
08-31 12:41 WARNING  MemStatAuditor    WARNING INFO message limit (500) reached for MemStatAuditor. Suppressing further output.

    I presume as there were some changes relating to ViewAlgs, that this may have changed something there? I don't anticipate my changes reduced the number of MemStatAuditor messages (though it doesn't seem like a troubling change). I also don't know whether this test has been looked at closely, but I run it when I test my changes.

    Thanks, Ian

  • Karolos Potamianos added review-approved label and removed review-pending-level-2 label

    added review-approved label and removed review-pending-level-2 label

  • Walter Lampl added review-user-action-required label

    added review-user-action-required label

  • I
    Ian Allan Connelly @iconnell ·
    Author

    Dear shifters

    It would be super useful to know who is making changes to the labels and what the requirements are. I will tag @nkoehler incase he has some feedback on the T0 test. I will also in the meantime try and run it with one of the latest builds and see if the same message occurs in case I do need to understand why this message is no longer printed.

    Ian

  • Ben Bruers
    Ben Bruers @bbrueers ·
    Developer

    Hi @wlampl, you marked the MR as review-user-action-required, I suppose due to the T0 test output? Should we remove the review-approved?

  • Walter Lampl
  • Walter Lampl
    Walter Lampl @wlampl ·
    Owner

    It was about a comment (above) that I apparently forgot to 'submit' (new gitlab feature).

    • Walter
  • I
    Ian Allan Connelly @iconnell ·
    Author

    In addition to the review above, I reran my FrozenT0 test a couple of times. One time I got a message about the memory usage increasing, and another time I got no messages at all. I therefore hope/believe that the changing messages relate to the machines I was running on (through a multi-core condor submission which could result in slightly different memory management between jobs). I upload the fully successful log message here: RunTier0Tests-new.log

    Ian

  • I
    Ian Allan Connelly @iconnell ·
    Author

    I've just pushed changes to remove the const cthis switching to this and do not see any changes in the Frozen T0 test - RunTier0Tests-2.log. Just waiting for the CI to pick up the changes and make sure there are no other issues appearing.

  • Ian Allan Connelly added 1 commit

    added 1 commit

    • 990a05ca - Removing const calls to this before calling const function

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
    • Please register or sign in to reply