Adding TruthMatching histogram to RDOAnalysis

Manually adding change from 21.9 to master too: !35539 (merged)

FYI: @jchapman

This merge request affects 1 package:

• Simulation/Tools/RDOAnalysis

Adding @jchapman ,@vpascuzz as watchers

added Simulation master review-pending-level-1 labels

CI Result SUCCESS (hash d56b6290)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 18655]

Not that this is always bad, but it looks like there is a good chunk of cut/paste code to do the matching. Changes look fairly straight forward and apparently coming from another release, so this is, I'm sure, OK. Marking for L2 because this is a section of the code I do not understand well! Hopefully a very quick L2 review!

added review-pending-level-2 label and removed review-pending-level-1 label

I'm also not an expert, but didn't see any obvious problems. This code does use raw pointers, but that was inherited from the existing code, no not the fault of this MR. However, it would be good to have a follow-up MR to change the raw pointers to smart pointers. That said, I'll mark this MR as approved. ~Joe (L2)

added review-approved label and removed review-pending-level-2 label

resolved all threads

merged

mentioned in commit 67a79b76

added sweep:ignore label

mentioned in merge request !35539 (merged)