TrigConfigSvc: remove usage of IJobOptionsSvc

Remove usage of the deprecated IJobOptionSvc from legacy trigger configuration code:

DSConfigSvc:

• Query the list of folders directly via IIOVDbSvc instead of reading its property from the JobOptionsSvc.

HLTConfigSvc:

• In order to avoid migrating to IOptionsSvc, remove all code related to reading prescales in a partition for the legacy trigger as we don't support this anymore.

None of this should have an impact on the Run-3 trigger. There will be a separate MR for the TrigConf::JobOptionsSvc, which will need more thorough testing.

cc @stelzer @mark @rbielski

Trigger/TrigConfiguration/TrigConfigSvc/src/DSConfigSvc.cxx

@@ -2,12 +2,11 @@
   Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
-// $Id: DSConfigSvc.cxx 742408 2016-04-23 18:55:57Z stelzer $
 
 #include "GaudiKernel/IIncidentSvc.h"
 #include "GaudiKernel/Incident.h"
-#include "GaudiKernel/IJobOptionsSvc.h"
 #include "AthenaKernel/errorcheck.h"
+#include "AthenaKernel/IIOVDbSvc.h"
 
 #include "CoolKernel/Record.h"
 
@@ -84,8 +83,7 @@ TrigConf::DSConfigSvc::DSConfigSvc( const std::string& name,
    m_hltPsKey( 0 ),
    m_lvl1BgKey( 0 ),
    m_configSrc( "" ),
-   m_detstore( "StoreGateSvc/DetectorStore", name ),
-   m_folders( "" )
+   m_detstore( "StoreGateSvc/DetectorStore", name )
 {
    m_configSourceString="dblookup";
    m_dbServer="TRIGGERDB";
@@ -105,14 +103,14 @@ TrigConf::DSConfigSvc::initialize() {
    // get detector store
    CHECK( m_detstore.retrieve() );
 
-   ServiceHandle< IJobOptionsSvc > jobOptionsSvc( "JobOptionsSvc", name() );
-   if( jobOptionsSvc.retrieve().isFailure() ) {
-      ATH_MSG_WARNING( "Cannot retrieve JobOptionsSvc" );
+   ServiceHandle< IIOVDbSvc > iovDbSvc( "IOVDbSvc", name() );
+   if( iovDbSvc.retrieve().isFailure() ) {
+      ATH_MSG_WARNING( "Cannot retrieve IOVDbSvc" );
    } else {
-      const Gaudi::Details::PropertyBase* p =
-         Gaudi::Utils::getProperty( jobOptionsSvc->getProperties( "IOVDbSvc" ), "Folders" );   
-      if( p ) m_folders = p->toString();
-      ATH_MSG_DEBUG( "The string 'folders' is: " << m_folders );
+      IIOVDbSvc::KeyInfo info;
+      for ( const std::string& key : iovDbSvc->getKeyList() ) {
+         if ( iovDbSvc->getKeyInfo(key, info) ) m_folders.insert(info.folderName);
+      }
    }
 
    const bool multichannel  = true;
@@ -891,11 +889,5 @@ TrigConf::DSConfigSvc::assignPrescalesToChains(uint /*lumiblock*/) {
 
 bool 
 TrigConf::DSConfigSvc::hasFolder( const std::string& folder_name ){
-
-   if( m_folders.find( folder_name ) != string::npos ) {
-      return true;
-   } else {
-      return false;
-   }
+   return m_folders.find( folder_name ) != m_folders.end();
 }
-