TrigConfigSvc: remove usage of IJobOptionsSvc
Remove usage of the deprecated IJobOptionSvc
from legacy trigger configuration code:
DSConfigSvc
:
- Query the list of folders directly via
IIOVDbSvc
instead of reading its property from the JobOptionsSvc.
HLTConfigSvc
:
- In order to avoid migrating to
IOptionsSvc
, remove all code related to reading prescales in a partition for the legacy trigger as we don't support this anymore.
None of this should have an impact on the Run-3 trigger. There will be a separate MR for the TrigConf::JobOptionsSvc
, which will need more thorough testing.
Merge request reports
Activity
added Trigger master review-pending-level-1 labels
- Resolved by Frank Winklmeier
Hi @fwinkl
I think this MR is fine. However, once we move from the XML to the JSON menus, I plan a thorough cleanup of the config services. So not sure it is worth the effort now, unless you want to remove the Gaudi::IJobOptionsSvc from ATLAS sw.
CI Result SUCCESS (hash ffe78f72)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 19844]added review-approved label and removed review-pending-level-1 label
mentioned in commit 677540d9
added sweep:ignore label
mentioned in merge request !36519 (merged)