Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 167
    • Merge requests 167
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !36196

Divide ADC,TDC of sMDT with HPTDC digitization chip by 4 to give same ticksize as MDT chambers

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Edward Diehl requested to merge diehl/athena:BMGTDC into master Sep 04, 2020
  • Overview 29
  • Commits 2
  • Pipelines 2
  • Changes 3

Divide ADC,TDC of sMDT with HPTDC digitization chip by 4 to give same ticksize as MDT chambers. This applies to BMG and new BIS7 chambers being installed in LS2, all of which use the HPTDC digitization chip. By adjusting ticksize in PrepRawData, reconstruction with these chambers will be done identically to other MDT chambers without further code changes. Hence, can remove special treatment of BMG in MdtCalibrationTool. Also modify MdtDigitizationTool so that BMG, BIS7 will use HPTDC ticksize in MC data. This change fixes reconstruction of BMG chambers by altering ADC values which causes timeslew correction to be made and ADC cuts to work. Due to altered ADC RunTier0Tests.py fails q431.ESD and q431.ESD tests, see attached log file.RunTier0Tests.log

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: BMGTDC