Use new RegionSelector for Partial Event Building
Follow-up from !36883 (merged) and RegionSelector migration in general (ATR-19657) -- fully migrate TrigPartialEventBuilding.
The migration simplifies the code, which is great to see. The specific changes made:
- Use ToolHandleArray of RegSelTools in RoIPEBInfoWriterTool and provide helper function to configure them. The updated configuration calls the
RegSelToolConfig
functions directly so there is no need to introduce any extra Enums - the function names fromRegSelToolConfig.py
serve as an Enum. - Adapt the configuration of the clients in TriggerMenuMT and TrigP1Test.
- Fix handle initialisation in RegSelTool - if a handle is not intended for use, it should be initialised with
false
passed in the argument. Otherwise, such configuration leads to scheduler stalls.
It seems !36883 (merged) or something else recently broke the PEB code as I was not seeing all ROBs being added in the latest nightly. Not sure what exactly was broken, but this MR restores the PEB ROB lists that are produced with Athena 22.0.18. I was checking this by comparing debug output of the RoIPEBInfoWriterTool from test_trigP1_PEB_DS_build.py
.
cc @sutt
Merge request reports
Activity
added Geometry Trigger TriggerMenu master review-pending-level-1 labels
This looks very nice. There was a one instance of the config for this which I missed and broke the trigP1_PEB_DS_build test yesterday, but I fixed that with
!37120 (merged) yesterday I think, so maybe I messed something else up there. This is a better implementation though.Cheers Mark
CI Result SUCCESS (hash 1e9cb74b)Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 21720]added review-approved label and removed review-pending-level-1 label
mentioned in commit fcb3b4a1
added sweep:ignore label