tauRecTools: drop "TauEtaCalib" 4-momentum calibration

Hello,

This MR is dropping the "TauEtaCalib" 4-momentum calibration from the tau reconstruction. This is a calo-only calibration which is almost identical to the "TauEnergyScale" calibration, except that a tiny correction is applied to the reconstructed calo-only eta to compensate for a tiny average bias (correction derived w.r.t. truth tau visible eta). Given the poor calo-only angular resolution, an absolute eta correction of at most 0.005 on eta is irrelevant in terms of tau performance. We could consider deploying an MVA regression at xAOD level to improve the angular resolution, so we don't need this intermediate momentum calibration in the reconstruction. Benefit: there will be one less tool scheduled (we used to call this tool twice), and a bunch of floats are no longer saved in the xAOD. In the few places where we were using the TauEtaCalib calibration, we are now using the TauEnergyScale calibration.

This MR affects a number of xAOD output variables, but the changes are very small and under control. For instance, for our final MVA pt, the relative change in the average pt is ~2.5e-4. The "TauEtaCalib" variables are now 0. Same for TauJetParameters::TESCalibConstant and TauJetParameters::TESOffset (not useful to keep). The rest is noise.

Py:diff-root         INFO  [TauJetsAux.BDTJetScoreSigTrans]: 38 leaves differ
Py:diff-root         INFO  [TauJetsAux.RNNEleScore]: 2 leaves differ
Py:diff-root         INFO  [TauJetsAux.RNNEleScoreSigTrans]: 30 leaves differ
Py:diff-root         INFO  [TauJetsAux.RNNJetScore]: 3 leaves differ
Py:diff-root         INFO  [TauJetsAux.RNNJetScoreSigTrans]: 35 leaves differ
Py:diff-root         INFO  [TauJetsAux.TESCalibConstant]: 64 leaves differ
Py:diff-root         INFO  [TauJetsAux.eta]: 14 leaves differ
Py:diff-root         INFO  [TauJetsAux.etaFinalCalib]: 14 leaves differ
Py:diff-root         INFO  [TauJetsAux.etaPanTauCellBased]: 14 leaves differ
Py:diff-root         INFO  [TauJetsAux.etaTauEtaCalib]: 64 leaves differ
Py:diff-root         INFO  [TauJetsAux.mPanTauCellBased]: 8 leaves differ
Py:diff-root         INFO  [TauJetsAux.phiTauEtaCalib]: 64 leaves differ
Py:diff-root         INFO  [TauJetsAux.pt]: 63 leaves differ
Py:diff-root         INFO  [TauJetsAux.ptFinalCalib]: 63 leaves differ
Py:diff-root         INFO  [TauJetsAux.ptPanTauCellBased]: 14 leaves differ
Py:diff-root         INFO  [TauJetsAux.ptTauEtaCalib]: 64 leaves differ
Py:diff-root         INFO  [TauJetsAuxDyn.eta_combined]: 40 leaves differ
Py:diff-root         INFO  [TauJetsAuxDyn.m_combined]: 39 leaves differ
Py:diff-root         INFO  [TauJetsAuxDyn.pt_combined]: 63 leaves differ

I've also updated the trigger configuration.

Cheers, Bertrand

added Reconstruction Tau master labels

Tagging @cgrefe , @qbuat , @adbailey , @xiaozhon , @gipezzul , @ademaria , @malconad , @carquin for information.

added Trigger label

changed the description

added 1 commit

• 0c94018a - clean up deprecated options in trigger config

Compare with previous version

changed the description

added review-pending-level-1 label

This merge request affects 10 files:

• Reconstruction/PanTau/PanTauAlgs/Root/PanTauProcessor.cxx
• Reconstruction/tauRec/python/TauAlgorithmsHolder.py
• Reconstruction/tauRec/python/TauRecBuilder.py
• Reconstruction/tauRec/python/TauRecRunner.py
• Reconstruction/tauRecTools/Root/CombinedP4FromRecoTaus.cxx
• Reconstruction/tauRecTools/Root/TauCalibrateLC.cxx
• Reconstruction/tauRecTools/tauRecTools/TauCalibrateLC.h
• Trigger/TrigAlgorithms/TrigTauRec/python/TrigTauAlgorithmsHolder.py
• Trigger/TrigAlgorithms/TrigTauRec/python/TrigTauRecConfig.py
• Trigger/TrigAlgorithms/TrigTauRec/python/TrigTauRecConfigMT.py

Adding @goetz ,@martindl ,@ademaria ,@carquin ,@xiaozhon ,@adbailey ,@malconad as watchers

Jenkins please retry a build

This merge request affects 10 files:

• Reconstruction/PanTau/PanTauAlgs/Root/PanTauProcessor.cxx
• Reconstruction/tauRec/python/TauAlgorithmsHolder.py
• Reconstruction/tauRec/python/TauRecBuilder.py
• Reconstruction/tauRec/python/TauRecRunner.py
• Reconstruction/tauRecTools/Root/CombinedP4FromRecoTaus.cxx
• Reconstruction/tauRecTools/Root/TauCalibrateLC.cxx
• Reconstruction/tauRecTools/tauRecTools/TauCalibrateLC.h
• Trigger/TrigAlgorithms/TrigTauRec/python/TrigTauAlgorithmsHolder.py
• Trigger/TrigAlgorithms/TrigTauRec/python/TrigTauRecConfig.py
• Trigger/TrigAlgorithms/TrigTauRec/python/TrigTauRecConfigMT.py

Adding @goetz ,@martindl ,@ademaria ,@carquin ,@xiaozhon ,@adbailey ,@malconad as watchers

CI Result SUCCESS (hash 89aee069)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 22999]

CI Result SUCCESS (hash 0c94018a)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23010]

Marking for L2 to crosscheck as there are many changes in the MR (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

Looks good, thanks L2

added review-approved label

removed review-pending-level-2 label

merged

mentioned in commit 465f5159

added sweep:ignore label