Improve protection against missing four-vectors

This MR just implements a small change to the four-vector check before filling the histograms. This ensures that the standard four-vector histograms (neither EM nor const scale) are also filled.

This merge request affects 1 file:

• Reconstruction/Jet/JetMonitoring/Root/JetKinematicHistos.cxx

Adding @goetz as watcher

added DQ JetEtmiss Reconstruction master review-pending-level-1 labels

CI Result SUCCESS (hash 2650c1f8)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23350]

Minor changes One question - otherwise probably ready to go in.

• L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 5292d01d - Fixing clang warning

Compare with previous version

This merge request affects 1 file:

• Reconstruction/Jet/JetMonitoring/Root/JetKinematicHistos.cxx

Adding @goetz as watcher

added review-pending-level-1 label and removed review-user-action-required label

mentioned in merge request !38316 (merged)

CI Result SUCCESS (hash 5292d01d)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23565]

added review-approved label and removed review-pending-level-1 label

Can you resolve discussions if the issues are satisfied.

Hi @abarton ,

I can resolve the discussion but I was hoping to have maybe feedback from @ssnyder first if this resolves the clang warnings that Scott removed in the MR that was just merged: !38316 (merged)

I just would like to avoid that I put in a new MR and then it's being removed by Scott shortly afterwards again because of warnings and we end up in an infinite loop :) That's definitely not the best use of our time and not my intention. If there's any recommendation of what I should be running to check first if the warning really disappears then I would be happy to test it.

Thanks and cheers, Chris

added review-pending-expert label and removed review-approved label

hi -

What's there now isn't completely wrong anymore . Looks like it works only for two scale settings, but maybe that's intended.

However, it would be much better to do this by adding an appropriate interface to xAOD::Jet so that we don't hardcode the variable names here.

hi -

Thanks.

Hmm... i may have been too hasty in saying that the conditional could never be true. m_jetScale+"_pt" should be "_pt" for JetEMScaleMomentum, "pt" for JetConstitScaleMomentum, and "t" for JetAssignedScaleMomentum. So if there's a variable "pt", them it could be true for the second case. But that is in any case accidental.

Anyway, thanks for fixing it.

added 502 commits

• 5292d01d...6325287f - 501 commits from branch atlas:master
• ded05e22 - Switching to string for four-vector check

Compare with previous version

resolved all threads

This merge request affects 4 files:

• Reconstruction/Jet/JetMonitoring/JetMonitoring/JetKinematicHistos.h
• Reconstruction/Jet/JetMonitoring/Root/JetKinematicHistos.cxx
• Reconstruction/Jet/JetMonitoring/python/HIJetHistoTools.py
• Reconstruction/Jet/JetMonitoring/python/JetHistoTools.py

Adding @goetz as watcher