JetMonitoring: Fix clang warning.

The isAvailable check here

  if(j.isAvailable<float>((m_jetScale)+"_pt"))

doesn't do what one expects. This is (int)+(char*), which is not very meaningful.

There actually doesn't seem to be a good way of doing this given the current Jet interface, so just remove this test and hope for the best.

This merge request affects 1 file:

• Reconstruction/Jet/JetMonitoring/Root/JetKinematicHistos.cxx

Adding @goetz as watcher

added DQ JetEtmiss Reconstruction master review-pending-level-1 labels

Hi @ssnyder ,

I've prepared a MR here

!38175 (diffs, comment 3953931)

that I think solves the problem. Could you maybe take a look if you spot anything obvious that would cause problems again with clang?

Thanks and cheers, Chris

Just to be clear --- it isn't that it it caused problems with clang. The real issue is that is that it was completely wrong --- that if condition would never be true. (Was it tested?)

Hi Scott!

Thanks for the feedback on the other thread. I will get back to that soon.

I've put in the other MR that you point out as being completely wrong. I understand why you say it, I was confused as well (and still am) that it would work however I tested it and it worked and did exactly what I needed it to do. We had an error message previously and it did disappear after putting in this "fix" because it exited the function early for the cases that I wanted to flag but still filled the histograms correctly for the other cases. Either way, I'm sorry to have caused extra work for you and I'm also happier if we have an implementation that does not only do what we want it to do but that also makes sense :)

Cheers, Chris

CI Result SUCCESS (hash c616c908)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23560]

added review-approved label and removed review-pending-level-1 label

mentioned in commit be67ed76

merged

mentioned in merge request !38175 (merged)

added sweep:ignore label