Cleanup memory handling of sTGC_Digitization

Cleanup memory handling of sTGC_Digitization. As we had some issues running sTGC with pile-up I just cleaned the memory in the whole package.

/cc @nkoehler @alaurier @jchapman

added alsoTargeting:21.3 alsoTargeting:21.9 labels

This merge request affects 4 files:

• MuonSpectrometer/MuonDigitization/sTGC_Digitization/sTGC_Digitization/sTgcDigitMaker.h
• MuonSpectrometer/MuonDigitization/sTGC_Digitization/sTGC_Digitization/sTgcDigitizationTool.h
• MuonSpectrometer/MuonDigitization/sTGC_Digitization/src/sTgcDigitMaker.cxx
• MuonSpectrometer/MuonDigitization/sTGC_Digitization/src/sTgcDigitizationTool.cxx

Adding @jchapman ,@rosati ,@wleight ,@nkoehler as watchers

added Digitization MuonSpectrometer master review-pending-level-1 labels

added review-user-action-required label and removed review-pending-level-1 label

CI Result FAILURE (hash 040410fd)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 5
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 4
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23442]

added 1 commit

• ca599115 - Cleanup memory handling of sTGC_Digitization

Compare with previous version

This merge request affects 4 files:

• MuonSpectrometer/MuonDigitization/sTGC_Digitization/sTGC_Digitization/sTgcDigitMaker.h
• MuonSpectrometer/MuonDigitization/sTGC_Digitization/sTGC_Digitization/sTgcDigitizationTool.h
• MuonSpectrometer/MuonDigitization/sTGC_Digitization/src/sTgcDigitMaker.cxx
• MuonSpectrometer/MuonDigitization/sTGC_Digitization/src/sTgcDigitizationTool.cxx

Adding @jchapman ,@rosati ,@wleight ,@nkoehler as watchers

added review-pending-level-1 label and removed review-user-action-required label

mentioned in merge request !38257 (merged)

resolved all threads

CI Result SUCCESS (hash ca599115)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23477]

I think it is ready to go, approving (L1).

added review-approved label and removed review-pending-level-1 label

I think some of these std::lists can be safety made into std::vector but this can wait for another time. Merging.

mentioned in commit 19793364

merged

added sweep:done label

added sweep:failed label

Sweep summary
failed:

• 21.3
• 21.9

There are a lot of conflicts ... Is any of the muon people interested in backporting this? Otherwise it will probably stay master-only.

removed sweep:failed label

removed alsoTargeting:21.9 label

removed alsoTargeting:21.3 label