Skip to content
Snippets Groups Projects

Code cleanup in the ReadAlignTrans algorithm

Merged Vakhtang Tsulaia requested to merge tsulaia/athena:master-ReadAlignTrans into master

Dropped the dependency on IGeoModelSvc::align(). Also moved all headers into src directory

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This merge request affects 14 files:

    • DetectorDescription/DetDescrCond/DetDescrCondExample/CMakeLists.txt
    • DetectorDescription/DetDescrCond/DetDescrCondExample/DetDescrCondExample/CoolHistExample.h
    • DetectorDescription/DetDescrCond/DetDescrCondExample/DetDescrCondExample/ReadAlignTrans.h
    • DetectorDescription/DetDescrCond/DetDescrCondExample/DetDescrCondExample/ReadTopTrans.h
    • DetectorDescription/DetDescrCond/DetDescrCondExample/DetDescrCondExample/ReadWriteCoolStrFile.h
    • DetectorDescription/DetDescrCond/DetDescrCondExample/src/CoolHistExample.cxx
    • DetectorDescription/DetDescrCond/DetDescrCondExample/src/CoolHistExample.h
    • DetectorDescription/DetDescrCond/DetDescrCondExample/src/ReadAlignTrans.cxx
    • DetectorDescription/DetDescrCond/DetDescrCondExample/src/ReadAlignTrans.h
    • DetectorDescription/DetDescrCond/DetDescrCondExample/src/ReadTopTrans.cxx
    • DetectorDescription/DetDescrCond/DetDescrCondExample/src/ReadTopTrans.h
    • DetectorDescription/DetDescrCond/DetDescrCondExample/src/ReadWriteCoolStrFile.cxx
    • DetectorDescription/DetDescrCond/DetDescrCondExample/src/ReadWriteCoolStrFile.h
    • DetectorDescription/DetDescrCond/DetDescrCondExample/src/components/DetDescrCondExample_entries.cxx

    Adding @nkoehler ,@rbianchi as watchers

  • :white_check_mark: CI Result SUCCESS (hash 1cb47a7c)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 23464]

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 66b27d31

Please register or sign in to reply
Loading