Patch for running MC TriggerDB from SQLite

Discussed in ATR-22123

@nozturk @mavogel @aundrus

Will also request for 21.0-mc16a/d later

added 21.0 Trigger labels

This merge request affects 8 files:

• Trigger/TrigConfiguration/TrigConfStorage/TrigConfStorage/SessionMgr.h
• Trigger/TrigConfiguration/TrigConfStorage/TrigConfStorage/StorageMgr.h
• Trigger/TrigConfiguration/TrigConfStorage/src/ReplicaSorter.cxx
• Trigger/TrigConfiguration/TrigConfStorage/src/ReplicaSorter.h
• Trigger/TrigConfiguration/TrigConfStorage/src/SessionMgr.cxx
• Trigger/TrigConfiguration/TrigConfigSvc/TrigConfigSvc/ConfigSvcBase.h
• Trigger/TrigConfiguration/TrigConfigSvc/python/TrigConfigSvcUtils.py
• Trigger/TrigConfiguration/TrigConfigSvc/src/ConfigSvcBase.cxx

Adding @asonay ,@orlando ,@cmorenom ,@mark as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash e3489876)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 161
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 6
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45213]

Jenkins please retry a build

This merge request affects 8 files:

• Trigger/TrigConfiguration/TrigConfStorage/TrigConfStorage/SessionMgr.h
• Trigger/TrigConfiguration/TrigConfStorage/TrigConfStorage/StorageMgr.h
• Trigger/TrigConfiguration/TrigConfStorage/src/ReplicaSorter.cxx
• Trigger/TrigConfiguration/TrigConfStorage/src/ReplicaSorter.h
• Trigger/TrigConfiguration/TrigConfStorage/src/SessionMgr.cxx
• Trigger/TrigConfiguration/TrigConfigSvc/TrigConfigSvc/ConfigSvcBase.h
• Trigger/TrigConfiguration/TrigConfigSvc/python/TrigConfigSvcUtils.py
• Trigger/TrigConfiguration/TrigConfigSvc/src/ConfigSvcBase.cxx

Adding @asonay ,@orlando ,@cmorenom ,@mark as watchers

CI Result SUCCESS (hash e3489876)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45227]

I'm seeing one compiler warning:

/var/lib/jenkins/workspace/CI-MERGE-REQUEST/21.0/Trigger/TrigConfiguration/TrigConfigSvc/src/HLTConfigSvc.cxx:84:1: warning: 'virtual const TrigConf::HLTChainList* TrigConf::HLTConfigSvc::chainList() const' is deprecated [-Wdeprecated-declarations]

I'm not sure if this is directly related to the MR, could you please check?

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 9a1b5860 - Modified a comment

Compare with previous version

resolved all threads

The CI job was interrupted by networking problems. Restarted.

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigConfiguration/TrigConfStorage
• Trigger/TrigConfiguration/TrigConfigSvc

Affected files list will not be printed in this case

Adding @asonay ,@orlando ,@cmorenom ,@mark as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 9a1b5860)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 161
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 6
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45273]

Warnings look to be unrelated, approving (L1).

added review-approved label

removed review-pending-level-1 label

merged

mentioned in commit bf1e2be3

added sweep:done label

added sweep:failed label

Sweep summary
failed:

• master

Hello @nozturk, @mavogel, @aundrus

This MR seems to break RDOtoRDO step in test_reco_mc16e TCT job with the following errors:

• IOVDbSvc ERROR getAddress failed for folder /TRIGGER/HLT/HltConfigKeys
• IOVDbSvc ERROR COOL object not found in single-channel retrieve, folder /TRIGGER/HLT/HltConfigKeys currentTime
• IOVDbSvc ERROR COOL object not found in single-channel retrieve, folder /TRIGGER/HLT/PrescaleKey currentTime
• IOVDbSvc ERROR getAddress failed for folder /TRIGGER/LVL1/Lvl1ConfigKey
• IOVDbSvc ERROR COOL object not found in single-channel retrieve, folder /TRIGGER/LVL1/Lvl1ConfigKey currentTime

You can find the full log at: https://bigpanda.cern.ch//media/filebrowser/72186acb-13b6-4c2e-94ec-b0bdcb6ea89e/group.art/tarball_PandaJob_4911173730_ANALY_CERN_T0_ART/log.RDOtoRDOTrigger

I am going to revert the MR till a fix is provided to get this test running correctly.

Cheers, Rachid

mentioned in commit 3ed7ac44

mentioned in merge request !38907 (merged)

Hi @rmazini,

I just now see this request reversion, going to investigate. Certainly CI tests did not catch this.

We also saw this problem (I assume it is the same one) on a grid job and I provided a fix (!39271 (merged)). The fix unfortunately now doesn't compile because of the reversion.

Could you please next time also tag the author of the merge request before reverting it? Often a better solution can be found.

Best regards, Joerg

mentioned in merge request !39271 (merged)

failed sweeps need to be resolved (to either sweep:ignore or sweep:done) [L2 MR shifter]

mentioned in merge request !39712 (merged)

mentioned in commit 831e3a50