T/P Test Fixes, master branch (2020.12.11.)

Made sure that run_tpcnv_legacy_test(...) and run_tpcnv_test(...) would not interfere with each other. By choosing different (cache) variable names in them for looking up the script skeletons that they each need. And at the same time adding a bunch of quotes around file/directory names, to make the code more robust with directory names containing spaces.

This is to fix ATEAM-684. Which was revealed (but not caused) by !38853 (merged).

To be on the safe side, let's run a full-unit-tests suite. (That would've revealed the problem in !38853 (merged) as well...)

added bugfix full-unit-tests labels

This merge request affects 1 package:

• Database/AthenaPOOL/AthenaPoolUtilities

This merge request affects 1 file:

• Database/AthenaPOOL/AthenaPoolUtilities/cmake/AthenaPoolUtilitiesTestConfig.cmake

Adding @ssnyder ,@mnowak as watchers

added Database master review-pending-level-1 labels

CI Result FAILURE (hash 7394fc5b)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25034]

added 1 commit

• 48107e1b - Updated the indentation in the reference files.

Compare with previous version

This merge request affects 3 packages:

• Calorimeter/CaloCnv/CaloAthenaPool
• Database/AthenaPOOL/AthenaPoolUtilities
• Trigger/TrigEvent/TrigEventAthenaPool

Affected files list will not be printed in this case

Adding @pavol ,@ssnyder ,@mnowak as watchers

added Calorimeter JetEtmiss Trigger labels

CI Result FAILURE (hash 48107e1b)

	Athena	AthSimulation	AthGeneration	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25049]

added review-approved label and removed review-pending-level-1 label

Unit test failures seem unrelated and this is important to fix other issues.

resolved all threads

mentioned in commit c2cd0860

merged

added sweep:ignore label