Skip to content
Snippets Groups Projects

Optimization of Run-2 TGC-BW Coincidence Window

Merged Junpei Maeda requested to merge junpei/athena:run2TgcBwLUTopt_2020-12 into master

The storing method of the contents of Coincidence Windows for TGC Big-Wheel is changed for more optimization of memory usage by TGCTriggerDbAlg.
This is one of goal for ATR-21107.

As suggested by the last comment in !38485 (merged), a single std::unordered_map is adopted instead of a load of std::map instances. The unordered_map was faster and smaller memory usage when I compared.

The following test is successfully finished:

RecExCommon_links.sh; athena.py myTopOptions.py
Reco_tf.py --AMI q221 --inputRDOFile /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/TriggerTest/valid1.410000.PowhegPythiaEvtGen_P2012_ttbar_hdamp172p5_nonallhad.merge.RDO.e4993_s3214_r11315/RDO.17533168._000001.pool.root.1 --maxEvents 100 --athenaopts='--threads=1 --pmon=sdmonfp' --outputRDO_TRIGFile=myRDOTrigger.pool.root --steering=doRDO_TRIG --preExec all:"setMenu='LS2_v1_TriggerValidation_mc_prescale'"

Moreover, I confirmed to output same result of pT determination by the single muon sample.

Edited by Junpei Maeda

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas Koehler
  • Junpei Maeda added 1 commit

    added 1 commit

    • 07a6589a - add const variables and comments for hard-coded numbers

    Compare with previous version

  • This merge request affects 2 packages:

    • MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondSvc
    • Trigger/TrigT1/TrigT1TGC

    Affected files list will not be printed in this case

    Adding @rosati ,@wleight ,@kwhalen ,@nkoehler ,@afaulkne as watchers

  • :white_check_mark: CI Result SUCCESS (hash 07a6589a)

    Athena AthSimulation AthGeneration AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25282]

  • Pavol Strizenec resolved all threads

    resolved all threads

  • Seems fine to me now, approving.

    Pavol [as L2 MR shifter]

  • mentioned in commit 8bb8f885

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading