Optimization of Run-2 TGC-BW Coincidence Window

The storing method of the contents of Coincidence Windows for TGC Big-Wheel is changed for more optimization of memory usage by TGCTriggerDbAlg.
This is one of goal for ATR-21107.

As suggested by the last comment in !38485 (merged), a single std::unordered_map is adopted instead of a load of std::map instances. The unordered_map was faster and smaller memory usage when I compared.

The following test is successfully finished:

RecExCommon_links.sh; athena.py myTopOptions.py

Reco_tf.py --AMI q221 --inputRDOFile /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/TriggerTest/valid1.410000.PowhegPythiaEvtGen_P2012_ttbar_hdamp172p5_nonallhad.merge.RDO.e4993_s3214_r11315/RDO.17533168._000001.pool.root.1 --maxEvents 100 --athenaopts='--threads=1 --pmon=sdmonfp' --outputRDO_TRIGFile=myRDOTrigger.pool.root --steering=doRDO_TRIG --preExec all:"setMenu='LS2_v1_TriggerValidation_mc_prescale'"

Moreover, I confirmed to output same result of pT determination by the single muon sample.

Trigger/TrigT1/TrigT1TGC/src/TGCRPhiCoincidenceMatrix.cxx

@@ -67,10 +67,9 @@ TGCRPhiCoincidenceOut* TGCRPhiCoincidenceMatrix::doCoincidence()
   out->setIdSSC(m_SSCId);
 
   int j0 = -1;
-  int ptMax=-1;
+  int ptMax = 1;
   for( int j=m_nPhiHit-1; j>=0; j-=1){     // left half-SSC has priority when both output same pT
     int subsector;
-    int ptOut = -99;
     int chargeOut = 2;
     int CoincidenceTypeOut=-1;
 
@@ -80,9 +79,10 @@ TGCRPhiCoincidenceOut* TGCRPhiCoincidenceMatrix::doCoincidence()
       subsector = 4*(2*m_SSCId+m_r)+m_phi[j];
     }
     
-
     int type = m_map->getMapType(m_ptR, m_ptPhi[j]);
+
     // calculate pT of muon candidate
+    uint8_t ptOut = 0;   // 0 is no candidate.
     if(tgcArgs()->useRun3Config()){
       //Algorithm for Run3
       int pt=m_map->test_Run3(m_sectorLogic->getOctantID(),m_sectorLogic->getModuleID(),
@@ -93,19 +93,20 @@ TGCRPhiCoincidenceOut* TGCRPhiCoincidenceMatrix::doCoincidence()
       CoincidenceTypeOut=(type==0);
 
     } else {    // for Run-2
-      uint8_t pt = m_map->test(m_sectorLogic->getOctantID(),
-                               m_sectorLogic->getModuleID(), subsector,
-                               type, m_dR, m_dPhi[j]);
-      if(pt>0) ptOut = pt + 1;   // +1 is temporary numbering for the following codes
+      ptOut = m_map->test(m_sectorLogic->getOctantID(),
+                          m_sectorLogic->getModuleID(), subsector,
+                          type, m_dR, m_dPhi[j]);
     }
 
-    // Trigger Out
-    if( ptOut >= ptMax ){
+    // Trigger Out (only pT>0 candidate
+    if(ptOut >= ptMax) {
       ptMax = ptOut;
       out->clear();    
       out->setIdSSC(m_SSCId);
-      if(!tgcArgs()->useRun3Config()){out->setHit(ptMax+1);}// for Run2 Algo
-      else{out->setpT(ptMax);}// for Run3 Algo
+
+      if(!tgcArgs()->useRun3Config()) out->setHit(ptMax);  // for Run2 Algo
+      else                            out->setpT(ptMax);   // for Run3 Algo
+
       out->setR(m_r);
       out->setPhi(m_phi[j]);
       out->setDR(m_dR);