move code for LArFebHeader reading into separate function to avoid code-duplication

The LArRawDataReadingAlg and the LArRawCalibDataReadingAlg are both capable of producing a LArFebHeaderContainer out of the bytestream data they are reading.

Move the code doing so into a separate function to minimize code-duplication.

This merge request affects 1 package:

• LArCalorimeter/LArCnv/LArByteStream

This merge request affects 4 files:

• LArCalorimeter/LArCnv/LArByteStream/src/LArFebHeaderReader.cxx
• LArCalorimeter/LArCnv/LArByteStream/src/LArFebHeaderReader.h
• LArCalorimeter/LArCnv/LArByteStream/src/LArRawCalibDataReadingAlg.cxx
• LArCalorimeter/LArCnv/LArByteStream/src/LArRawDataReadingAlg.cxx

Adding @pavol as watcher

added JetEtmiss LAr master review-pending-level-1 labels

CI Result SUCCESS (hash 370b9729)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25812]

Could the new files LArFebHeaderReader .cxx and .h files get a 2021 copyright statement? If they do, I think this can be approved.

Serhat (L1)

Looking back at the shifter instructions, the end year is not important. Fix at will. Approving now.

Serhat (L1)

added review-approved label and removed review-pending-level-1 label

Thanks.

I have another MR in flight that will update also the copyright statement.

• Walter

mentioned in merge request !39498 (merged)

merged

mentioned in commit 90cfdd61

added sweep:ignore label