Refactor and clean up the method for adding cells from the satellites.

Refactor and clean up the method for adding cells from the satellites using constaints/boxing. This might be relevant depending on the outcome of the discussion on the PC on if we keep this or not.

Mentioning @turra

Results should be identical RunTier0Tests.log

which means bug fixes are not included

This merge request affects 1 package:

• Reconstruction/egamma/egammaAlgs

This merge request affects 2 files:

• Reconstruction/egamma/egammaAlgs/src/egammaSuperClusterBuilder.cxx
• Reconstruction/egamma/egammaAlgs/src/egammaSuperClusterBuilder.h

Adding @goetz as watcher

added Egamma Reconstruction master review-pending-level-1 labels

CI Result SUCCESS (hash c37e4b9b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25829]

changed the description

added review-pending-level-2 label and removed review-pending-level-1 label

resolved all threads

removed review-pending-level-2 label

added review-approved label

Approving (L1)

mentioned in merge request !39509 (closed)

merged

mentioned in commit 3c9c5720

added sweep:ignore label

mentioned in merge request !39524 (merged)