Jet Hypo Rename and clean-up of VBENF chains

The VBENF chains have been renamed to fbdjnoshared to match other chains names that are now possible.

Handling of the hypo parameters, which appear in the chain name, has been improved.

@jbossios @valentem @khoo @peter

ATR-22572

added master label

changed title from Jet Hypo Rename and clean-up of VBENF chains to WIP Jet Hypo Rename and clean-up of VBENF chains

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@hrussell ,@malconad ,@ckaldero ,@carquin ,@ademaria ,@bernius as watchers

added JetEtmiss Trigger TriggerMenu review-pending-level-1 labels

removed JetEtmiss Trigger TriggerMenu review-pending-level-1 labels

changed the description

CI Result FAILURE (hash c88d8669)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25876]

added 76 commits

• c88d8669...403d7481 - 74 commits from branch atlas:master
• cb51883d - Merge remote-tracking branch 'upstream/master' into master-ATR22572
• 695b1928 - Jet hypo nomds: update Trigger ART ref files, remove unused variable from...

Compare with previous version

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@ademaria ,@okumura ,@carquin ,@bernius ,@hrussell ,@ckaldero ,@malconad ,@jpanduro as watchers

added JetEtmiss Trigger TriggerMenu changes-trigger-counts review-pending-level-1 labels

MR is currently WIP - awaiting reply from @rbielski as to how to handle apparently spurious chain count changes.

Today there were fewer unrelated chain counts differences seen when running the ART tests. Still not sure how we can have such differences.

Have updated the reference files.

Hi Peter, see ATR-22579 regarding the egamma changes

Hi TJ

This might explain how this happened, but my question really meant how is it we have a system that allows this to happen.

When a developer sees failing test results, for which the case is most probably unrelated to their current work, they have two possibilities - update the reference files without understanding the consequences, or go into wait state for an undefined about of time, possibly eternity, until the unrelated cause goes away. Or not is the result is not unrelated, but how does one tell ....

Neither approach seems satisfactory.

Is it impossible to devise a system whereby one can follow a well documented set of instructions, and be provided with a system that does not contain multiple updates, so that development starts with a clean test result (no failures) against which changes can unambiguously checked?

Peter

CI Result FAILURE (hash 695b1928)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25916]

again - seems unrelated to this MR

changed title from WIP Jet Hypo Rename and clean-up of VBENF chains to Jet Hypo Rename and clean-up of VBENF chains

changed the description

added 102 commits

• 695b1928...d73a6821 - 101 commits from branch atlas:master
• 70708563 - Merge remote-tracking branch 'upstream/master' into master-ATR22572

Compare with previous version

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@ademaria ,@okumura ,@carquin ,@bernius ,@hrussell ,@ckaldero ,@malconad ,@jpanduro as watchers

CI Result SUCCESS (hash 70708563)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25950]

Jenkins please retry a build

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@ademaria ,@okumura ,@carquin ,@bernius ,@hrussell ,@ckaldero ,@malconad ,@jpanduro as watchers

CI Result SUCCESS (hash 70708563)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 25965]

Code changes look fine, approving. Pienpen (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 0a56170c

added sweep:ignore label

mentioned in merge request !39420 (closed)