Cleanup in the codes that will be migrated to HepMC3
In this MR:
- remove stray comments
- use std:: namespace explicitely
- fix soem formating
- some small migration to HepMC3
Merge request reports
Activity
This merge request affects 6 packages:
- PhysicsAnalysis/D3PDMaker/TruthD3PDAnalysis
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth
- PhysicsAnalysis/TruthParticleID/McParticleTools
- PhysicsAnalysis/TruthParticleID/McParticleUtils
- Simulation/G4Utilities/MCTruthSimAlgs
- Tracking/TrkTruthTracks/TrkTruthTrackTools
Affected files list will not be printed in this case
Adding @zmarshal ,@jchapman ,@vpascuzz ,@amorley as watchers
added Analysis Derivation Simulation Tracking master review-pending-level-1 labels
❎ CI Result FAILURE (hash fa36ab9f)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals ✅ ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ ✅ make ⭕ ✅ ✅ ✅ ✅ required tests ⭕ ✅ ✅ ✅ ✅ optional tests ✅ ✅ ✅ ✅ ✅ Full details available on this CI monitor view
⭕ Athena: number of compilation errors 1, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthAnalysis: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 26101]This merge request affects 6 packages:
- PhysicsAnalysis/D3PDMaker/TruthD3PDAnalysis
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth
- PhysicsAnalysis/TruthParticleID/McParticleTools
- PhysicsAnalysis/TruthParticleID/McParticleUtils
- Simulation/G4Utilities/MCTruthSimAlgs
- Tracking/TrkTruthTracks/TrkTruthTrackTools
Affected files list will not be printed in this case
Adding @zmarshal ,@jchapman ,@vpascuzz ,@amorley as watchers
✅ CI Result SUCCESS (hash bfeccc25)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals ✅ ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ ✅ make ✅ ✅ ✅ ✅ ✅ required tests ✅ ✅ ✅ ✅ ✅ optional tests ✅ ✅ ✅ ✅ ✅ Full details available on this CI monitor view
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthAnalysis: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 26119]added review-approved label and removed review-pending-level-1 label
mentioned in commit 9ca54d7e
added sweep:ignore label