Update the FTAG PHYSVAL code.

This is the code update to the FTAG PHYSVAL code, introducing a large set of new variables and features (related to my QT https://its.cern.ch/jira/browse/AFT-473).

Also related to this issue: https://its.cern.ch/jira/browse/AFT-497.

added 1 commit

• 8374d698 - Increase the jet phi number of bins, just for the next round.

Compare with previous version

added 1 commit

• 5d52194d - Remove all tau histograms.

Compare with previous version

added 1 commit

• ad99c3e9 - Just refer to the tutorial in the README in the scripts folder.

Compare with previous version

added 2 commits

• 7ac5f928 - Small changes in histogram binning.
• 68896493 - Small changes in folder structure.

Compare with previous version

added 2 commits

• fe295f01 - Adapt the y axis labels to showcase if the histo is filled with MC events, jets or tracks.
• 232cb6b0 - Change the efficiency vs Lxy to use the truth Lxy.

Compare with previous version

added 3475 commits

• 232cb6b0...cae28bea - 3473 commits from branch atlas:master
• 208b710c - Merge branch 'master' into ftagphysval-master-2020-06-16
• 656bbcba - Add PV x, y, z to the histograms.

Compare with previous version

added 1 commit

• 3a52a36a - Add IPxD weight C of tracks (+ rename variables in the code).

Compare with previous version

@duperrin

added 15 commits

• 46c86e15 - Add the splitting in jet truth label also for number of good tracks in SV1 and...
• 6e7eacb5 - Add a script to rename the histos in the files generated by the old code to the new scheme.
• cf08f43c - Update the renaming script to also handle ttbar samples.
• cce89235 - Add the deltaR between the truth B/C hadron and the jet.
• 9ca962b1 - Adapt the histogram ranges for some variables, especially fractions.
• 5f1b2e3b - Update the draw ROC curves script and add a python script that makes a...
• d1c01197 - Update range for IPxD grade of tracks.
• ab8ae424 - Add RNNIP and remove MV2c10mu and MV2c10rnn.
• e8b218ec - Implement the new track-to-truth associaltion scheme and adapt the categories.
• 91763284 - Add proper RNNIP working point values.
• 43a40f99 - Fix a few bugs in the comparison script.
• fead9953 - Change binning for number of IPxD tracks and SV1 number of good tracks.
• 0daaf085 - Update WP definitions to the numbers read from the CDI and make only 70% WP...
• ebcfa783 - Remove old unused track-truth method.
• c735087f - Add the beamspot weight as weight to each histogram fill.

Compare with previous version

Hi @jferrand and @miochoa,

this is the MR for the large update to the FTag Physval code.

The commit implementing the use of the beamspot weight is here: !39636 (c735087f)

Currently we're doing a few last checks; I think we will be able to un-WIP the MR the next days.

Best,
Judith :)

Thanks Judith!

added 3 commits

• d3e27923 - Fix small bug in the comparison script.
• f0c9158d - Fix range of SV1 number of good tracks.
• 51bfdb70 - Update copyright statements.

Compare with previous version

marked this merge request as ready

WARNING: big files (>100K) are found in the changeset

144K in file PhysicsAnalysis/JetTagging/JetTagValidation/JetTagDQA/src/BTaggingValidationPlots.cxx

This merge request affects 3 packages:

• Event/xAOD/xAODBTagging
• PhysicsAnalysis/JetTagging/JetTagValidation/JetTagDQA
• PhysicsAnalysis/PhysicsValidation/PhysValMonitoring

Affected files list will not be printed in this case

Adding @duperrin ,@guirriec ,@akraszna ,@dguest ,@cvarni ,@lidiaz as watchers

added Analysis BTagging Derivation EDM JetEtmiss master review-pending-level-1 labels

just for reference, a private validation round comparing the previous 'standard' histograms to the ones produced with these code updates can be found here: http://atlas-computing.web.cern.ch/atlas-computing/links/PhysValDir/Btagging/private_30-03-21/task2/
The few changes observed are expected and described here: https://indico.cern.ch/event/1022215/#10-status-of-new-ftag-physics

CI Result SUCCESS (hash 51bfdb70)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30920]

changed the description

New files and classes are created in this MR, I think this should be considered by L2

Sergei L1

added review-pending-level-2 label and removed review-pending-level-1 label

Very minor comment: maybe the new python scripts can have the CERN Copyright.

Cheers, Abhishek [L2]

added 1 commit

• 5065e57e - Update copyright statements.

Compare with previous version

resolved all threads

WARNING: big files (>100K) are found in the changeset

144K in file PhysicsAnalysis/JetTagging/JetTagValidation/JetTagDQA/src/BTaggingValidationPlots.cxx

This merge request affects 3 packages:

• Event/xAOD/xAODBTagging
• PhysicsAnalysis/JetTagging/JetTagValidation/JetTagDQA
• PhysicsAnalysis/PhysicsValidation/PhysValMonitoring

Affected files list will not be printed in this case

Adding @duperrin ,@guirriec ,@akraszna ,@dguest ,@cvarni ,@lidiaz as watchers

added review-pending-level-1 label and removed review-pending-level-2 label

CI Result SUCCESS (hash 5065e57e)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 31042]

added review-approved label and removed review-pending-level-1 label

Comments by L2 were implemented, CI successful. Approving... Lino (L1)

merged

mentioned in commit 48de54a0

added sweep:ignore label