Add DetCommon project

To address the LCG layer issues observed in ATLINFR-3977, we decided to build a separate DetCommon project that can be used by CTP/L1Calo instead of the full athena release (unlike the DetCommon project of SVN days, this is a completely standalone project and Athena will not build against it). Its configuration is mostly a copy of AthDataQuality, i.e. the project does not build a separate externals project (it just does a checkout for the cmake code). The LCG dependency should be kept the same as the corresponding TDAQ release.

The MR also contains a few cmake fixes to packages that are included in its build. I.e. it removes the TrigConf standalone (SA) libraries as there is no need to have separate names now.

cc @akraszna @stelzer @emoyse @elmsheus

changed the description

How would you feel about calling the project AthDetCommon instead? AnalysisBase will never have an Ath prefix short of merging it with AthAnalysis, but all the other projects could still share this prefix...

Hi Frank. The Athena projects we need in L1Calo were listed in ATLINFR-3977. Its more than just three TrigConf packages. Eg we also need L1Topo simulation packages, currently just the legacy ones but will also need the phase 1 topo simulation as well in future.

added 115 commits

• ba360500...489e5fd4 - 113 commits from branch atlas:master
• 19d475a5 - Add DetCommon project
• a3eac918 - TrigConfiguration: cmake fixes for DetCommon project

Compare with previous version

added 2 commits

• fde3cdc4 - Add DetCommon project
• 3291ac9d - TrigConfiguration: cmake fixes for DetCommon project

Compare with previous version

resolved all threads

mentioned in merge request atlasexternals!822 (merged)

added 65 commits

• 3291ac9d...fec1d151 - 63 commits from branch atlas:master
• 03c90e65 - Add DetCommon project
• ef23b76f - TrigConfiguration: cmake fixes for DetCommon project

Compare with previous version

Hi Frank,

I just noticed that you didn't copy

https://gitlab.cern.ch/atlas/athena/-/blob/master/Projects/AthDataQuality/cmake/skeletons/atlas_export_sanitizer.cmake.in

into your new DetCommon project. You would need a carbon-copy of that file in this project as well.

I know, I know. The way that LCG dependencies are written into our exported CMake files is kind of messed up. We should try to make the whole thing better / more robust at one point. But for now, without a file called skeletons/atlas_export_sanitizer.cmake.in present during the build, the exported configuration comes out as:

...
set_target_properties(DetCommon::CxxUtils PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/src/Control/CxxUtils;${_IMPORT_PREFIX}/\${LCG_RELEASE_BASE}/LCG_98python3/Boost/1.73.0/x86_64-centos7-gcc8-opt/include"
  INTERFACE_LINK_LIBRARIES "\${LCG_RELEASE_BASE}/LCG_98python3/Boost/1.73.0/x86_64-centos7-gcc8-opt/lib/libboost_program_options.so;\${LCG_RELEASE_BASE}/LCG_98python3/Boost/1.73.0/x86_64-centos7-gcc8-opt/lib/libboost_regex.so;\${LCG_RELEASE_BASE}/LCG_98python3/Boost/1.73.0/x86_64-centos7-gcc8-opt/lib/libboost_filesystem.so;\${LCG_RELEASE_BASE}/LCG_98python3/Boost/1.73.0/x86_64-centos7-gcc8-opt/lib/libboost_thread.so;-lpthread;\${LCG_RELEASE_BASE}/LCG_98python3/Boost/1.73.0/x86_64-centos7-gcc8-opt/lib/libboost_system.so;\${LCG_RELEASE_BASE}/LCG_98python3/Boost/1.73.0/x86_64-centos7-gcc8-opt/lib/libboost_timer.so;\${LCG_RELEASE_BASE}/LCG_98python3/Boost/1.73.0/x86_64-centos7-gcc8-opt/lib/libboost_unit_test_framework.so;\${LCG_RELEASE_BASE}/LCG_98python3/Boost/1.73.0/x86_64-centos7-gcc8-opt/lib/libboost_chrono.so;\${LCG_RELEASE_BASE}/LCG_98python3/Boost/1.73.0/x86_64-centos7-gcc8-opt/lib/libboost_date_time.so;\${LCG_RELEASE_BASE}/LCG_98python3/Boost/1.73.0/x86_64-centos7-gcc8-opt/lib/libboost_atomic.so;Threads::Threads;-Wl,--copy-dt-needed-entries"
  INTERFACE_SYSTEM_INCLUDE_DIRECTORIES "\${LCG_RELEASE_BASE}/LCG_98python3/Boost/1.73.0/x86_64-centos7-gcc8-opt/include"
)
...

Long story short, please add a file with that name to the new DetCommon project. Otherwise client projects won't be able to build against it.

Cheers, Attila

added 2 commits

• 6b9c7975 - Add DetCommon project
• 1d9246aa - TrigConfiguration: cmake fixes for DetCommon project

Compare with previous version

resolved all threads

marked this merge request as ready

This merge request affects 4 packages:

• Projects/DetCommon
• Trigger/TrigConfiguration/TrigConfData
• Trigger/TrigConfiguration/TrigConfIO
• Trigger/TrigConfiguration/TrigConfStorage

Affected files list will not be printed in this case

Adding @orlando ,@cmorenom ,@mark ,@akraszna ,@asonay as watchers

added Build Trigger master review-pending-level-1 labels