GeneratorObjectsTPCnv: Fix more P->T bugs.
1 unresolved thread
1 unresolved thread
- Need to add a GenRunInfo object.
- Can't add attributes to vertices/particles that aren't associated with an event.
- Screwed up 4-vectors.
cc Andrii @averbyts
Merge request reports
Activity
Filter activity
189 195 } 190 196 191 197 HepMC::GenParticlePtr 192 GenEventCnv_p1::createGenParticle( const GenParticle_p1& persPart, 198 GenEventCnv_p1::createGenParticle( [[maybe_unused]] HepMC::GenEvent* genEvt, 199 const GenParticle_p1& persPart, 193 200 ParticlesMap_t& partToEndVtx, 194 201 HepMC::DataPool& datapools) const 195 202 { 196 203 HepMC::GenParticlePtr p = datapools.getGenParticle(); 197 204 198 205 #ifdef HEPMC3 206 genEvt->add_particle (p); This is the only logical difference between the !41754 (merged)
plus
and this MR. I've implemented this via
vertex->add_particle_out(particle)Edited by Andrii Verbytskyi
Hi @ssnyder ,
as the MRs are almost identical (apart from the difference discussed above) and !41754 (merged) is merged, my suggestion would be to
- freeze this MR (but not delete)
- continue with the !41862 (merged)
- look if the "adding to vertex approach" is sufficient. If yes, close this MR. If no -- reuse parts of this MR or edit it.
In general "adding to a vertex" is a more robust approach, as it assures a correct hierarchy in the event. However, there might be cases in Athena where it might not be sufficient.
What is your opinion?
Best regards,
Andrii
Please register or sign in to reply