Skip to content

More improvements to try to get new configuration working.

Edward Moyse requested to merge emoyse/athena:master-more-muoncomb-config-fixes-Mar25 into master

This is a follow up to !39908 (closed)

This was mostly done by enabling wrapping (it's off by default) and using my comparison script: https://gitlab.cern.ch/emoyse/Scripts/-/blob/master/CompareConfigs.py

Changes to match old config

  • MuonTrackSummaryHelperToolCfg should use AtlasExtrap
  • InDetTrackSummaryHelperToolCfg should have InDet set to true
  • MooCandidateMatchingToolCfg should use MuonStraightLineExtrap
  • MuonCombinedInDetDetailedTrackSelectorToolCfg uses new AtlasTrackSummaryToolCfg
  • SolenoidalIntersectorCfg has same name as old config, to allow for deduplication
  • misc changes to match naming of oldconfiguration
  • Correct naming of MuonCombinedInDetCandidateAlgCfg and added missing LRT configuration (currently off by default)
  • Add missing MuonAlignmentErrorDbAlg to MuonGeometryConfig and added missed folder for MuonAlign errors

Improvements to configuration:

  • Added AtlasTrackSummaryToolCfg
  • Wrapping Debug commented out (will be removed once debugging finished)
  • switch MuonCreatorTool to use summarytool which knows about ID
  • added some more new flags to wrapping (will eventually need to handle this all properly)
  • MuonCombinedRecoConfig: Need to enable ID via Detector.Reco flags now
  • Temporarily comment out MuonAlignmentErrorDbAlg (causes lots of errors in some workflows)

As well as the usual unit tests, I also ran source test_DataOverlay_ConfigTest_Zmumu_Muon.sh locally (@tadej)

Edited by Edward Moyse

Merge request reports