Flow Element validation: Fix dE (PFO,FE) plot

This merge request fixed the PFO/FE comparison plots in the physval framework, namely a discrepancy in ratios of pT(PFO,FE) and deltaE(PFO,FE) due to incorrect scales used on the PFOs.

Have also added a temporary set of debugs on floating point bits and other auxvars, but should all only be called in debug mode only.

Thanks

Matt A.

This merge request affects 1 package:

• Reconstruction/PFlow/PFlowValidation/PFOHistUtils

This merge request affects 2 files:

• Reconstruction/PFlow/PFlowValidation/PFOHistUtils/src/FlowElement_LinkerPlots.cxx
• Reconstruction/PFlow/PFlowValidation/PFOHistUtils/src/PFO_FE_Comparison_PlotMaker.cxx

Adding @goetz ,@mhodgkin as watchers

added JetEtmiss Reconstruction master review-pending-level-1 labels

CI Result SUCCESS (hash ce2fb4ff)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30844]

added review-approved label and removed review-pending-level-1 label

Not very happy about the magic number as errorcode (how about an enum?) but accepting. Can you impove that in a subsequent MR?

• Walter

mentioned in commit 88139a9c

merged

Hi @wlampl

Which error code magic number are you referring to?

This is a debug statement on the compression of a cluster moment(following a private mail discussion on the topic). I can remove if needed?

The reason it was included in the first place is because of Cluster Moment compression (to check it), which I think is only apparent from the binary representation (if you propose a better solution, I will be happy to include it)

Thanks

Matt A.

resolved all threads

added sweep:ignore label