I noticed that the AFP code (for example: AFP_RawDataProviderTool ) is far from being thread-safe. It doesn't break our large-scale MT tests because most runs (including those we use for testing) don't contain any AFP data. We nevertheless run the AFP reco code, which produces empty containers in the ESD and AOD and prints per-event warnings
AFP_RawDataProvider.AFP_RawDataProviderTool WARNING vecRobs.size() == 0 StoreGateSvc WARNING retrieve(const): No valid proxy for object AFP_TDDigiCollection of type AFP_TDDigiCollection(CLID 1154879695) AFP_TDLocReco WARNING AFP_Collection_Reading Failed
The change proposed here turns the rec.doAFP flag off by default.