Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 159
    • Merge requests 159
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !42980

Turn rec.doAFP off by default

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Walter Lampl requested to merge wlampl/athena:noAFP into master Apr 27, 2021
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1

I noticed that the AFP code (for example: AFP_RawDataProviderTool ) is far from being thread-safe. It doesn't break our large-scale MT tests because most runs (including those we use for testing) don't contain any AFP data. We nevertheless run the AFP reco code, which produces empty containers in the ESD and AOD and prints per-event warnings

AFP_RawDataProvider.AFP_RawDataProviderTool        WARNING vecRobs.size() == 0
StoreGateSvc                                       WARNING retrieve(const): No valid proxy for object AFP_TDDigiCollection  of type AFP_TDDigiCollection(CLID 1154879695)
AFP_TDLocReco                                      WARNING AFP_Collection_Reading Failed

The change proposed here turns the rec.doAFP flag off by default.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: noAFP