Skip to content
Snippets Groups Projects

New LArCaliWave persistent version

Merged Pavol Strizenec requested to merge pavol/athena:fix_LArCaliWave into master
All threads resolved!

This should solve ATLLARONL-993

For SuperCell calibration data processing we need to store DAC in more then 16 bits. Therefore additional member for pulsedLine is added and DAC in is used in full 32 bits. Changed also TP converters and added a test for this new version.

Code is used only in LAr calibration data processing, not in standard reconstruction.

Merge request reports

Pipeline #2628478 passed

Pipeline passed for 38453104 on pavol:fix_LArCaliWave

Approval is optional

Merged by Edward MoyseEdward Moyse 4 years ago (May 21, 2021 7:23am UTC)

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks good. There seem to be a lot of leftover cout statements (presumably from debugging). It would be great if these could be tidied before this is approved but I won't insist if it need to go in urgently. Tom - L1 shifter

  • added 1 commit

    • 38453104 - address the shifter comments

    Compare with previous version

  • Pavol Strizenec resolved all threads

    resolved all threads

  • This merge request affects 5 packages:

    • LArCalorimeter/LArCalibTools
    • LArCalorimeter/LArCalibUtils
    • LArCalorimeter/LArCnv/LArCondTPCnv
    • LArCalorimeter/LArExample/LArCalibProcessing
    • LArCalorimeter/LArRawConditions

    Affected files list will not be printed in this case

    Adding @pavol as watcher

  • :white_check_mark: CI Result SUCCESS (hash 38453104)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 33916]

  • Edward Moyse mentioned in commit bee2307f

    mentioned in commit bee2307f

  • merged

  • Walter Lampl mentioned in merge request !58562 (merged)

    mentioned in merge request !58562 (merged)

  • Please register or sign in to reply
    Loading