Skip to content

Fix clients of LArCaliWave

Walter Lampl requested to merge wlampl/athena:fixLArCaliWaveCtor into 22.0

In MR !43561 (merged) the constructors of LArCaliWave where updated to take an additional parameter, int isPulsed. But not all clients where updated. Compilation worked only by luck, because the last parameter (unsigned flag) of the LArCaliWave-constructor has a default value. So the parameter that was meant to set the flag actually set isPulsed and the flag always defaulted to 0. The result is obviously wrong, but I think a real effect is only visible for the HEC and SuperCells.

This MR removes the default value of the last parameter of the constructor of LArCaliWave to find all instances of this mistake. (Hopefully) all clients are adjusted to the new constructor syntax.

This MR deletes also the obsolete LArTCM-stuff, this is to avoid a merge-conflict with master where these files are already deleted.

ping @pavol and @ekay

Merge request reports