Add jtau isolation in L1Topo EDM

Small MR to change the L1Topo EDM to include jtau isolation from jFex. The isolation is also propagated to GenericTob in case needed by decision algorithms in the future (not expected so far). Related to ATR-24449.

The isolation data codes energy values in units of 200 MeV as retrieved from here: https://gitlab.cern.ch/atlas/athena/-/blob/master/Event/xAOD/xAODTrigger/Root/jFexTauRoI_v1.cxx#L123

added L1Topo label

marked this merge request as draft

marked this merge request as ready

I made a few checks on this; there is something I don't quite understand; the jtau isolation is expected to be passed in units of 200 MeV but I see very large values (>50k) @serodrig @afaulkne , is this expected?

jenkins please retry a build

added 89 commits

• 25cb389e...2044a65f - 88 commits from branch atlas:master
• 3b16f778 - fix merge conflicts

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigT1/L1Topo/L1TopoEvent
• Trigger/TrigT1/L1Topo/L1TopoSimulation

Affected files list will not be printed in this case

Adding @jchapman ,@iriu ,@kwhalen ,@orlando ,@cmorenom ,@paulama ,@asonay ,@afaulkne as watchers

added JetEtmiss Tau Trigger master review-pending-level-1 labels

CI Result SUCCESS (hash 3b16f778)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 41991]

Hi @orlando,

can the thread above be resolved? Also, your fork is listed as inaccessible. Can you please make sure it's set to Internal (instead of Private)?

Thanks, Volker (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 7a876bb4 - fix jtaus isolation

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigT1/L1Topo/L1TopoEvent
• Trigger/TrigT1/L1Topo/L1TopoSimulation

Affected files list will not be printed in this case

Adding @jchapman ,@iriu ,@kwhalen ,@orlando ,@cmorenom ,@paulama ,@asonay ,@afaulkne as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

added urgent label

Marking this as urgent as it is needed for combined e/j taus implementation.

CI Result FAILURE (hash 7a876bb4)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 42265]

Jenkins please retry a build

This merge request affects 2 packages:

• Trigger/TrigT1/L1Topo/L1TopoEvent
• Trigger/TrigT1/L1Topo/L1TopoSimulation

Affected files list will not be printed in this case

Adding @jchapman ,@iriu ,@kwhalen ,@orlando ,@cmorenom ,@paulama ,@asonay ,@afaulkne as watchers

CI Result FAILURE (hash 7a876bb4)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 42280]

marked this merge request as draft

Mark draft and CI FAILURE. I will change the label.

Sergei L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 2a8d685f - fix cout

Compare with previous version

The CI failure is probably related to some cout left accidentally in the code. Should be fixed now.

marked this merge request as ready

This merge request affects 2 packages:

• Trigger/TrigT1/L1Topo/L1TopoEvent
• Trigger/TrigT1/L1Topo/L1TopoSimulation

Affected files list will not be printed in this case

Adding @jchapman ,@iriu ,@kwhalen ,@orlando ,@cmorenom ,@paulama ,@asonay ,@afaulkne as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 2a8d685f)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 42302]

Changes look good. Approving -- L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 363be49e

added sweep:ignore label