Remove unused/duplicated btagging code

This removes an unused track to jet associator, an unused tool that wraps the associator and some other b-tagging tools, and an unused algorithm that calls the the unused tool.

This code isn't used in trigger, reconstruction, or derivations, but it's named very similarly to existing code we do use, and it has a lot of overlapping functionality. It's built around an inheritance hierarchy that is similar to, but separate from, the one we use in our standard code. Basically the standard code we do use is evolution of everything I'm deleting here, but people seem to be maintaining both (probably out of confusion).

This makes figuring out what our code is doing very hard. Better to get rid of it.

@thuffman, @duperrin, this is a draft until I've verified that it doesn't change anything. [this is marked as ready.]

Jenkins please retry a build

added 1480 commits

• 29db792e...f4bcff84 - 1479 commits from branch atlas:master
• 260bfb0b - Remove unused track to jet associator code

Compare with previous version

I should ask @cpollard to take a look at this, he knows more about the association code than I do and can verify that it's safe to delete.

changed the description

It would be good to delete this. My only worry is that there is downstream (e.g. AnalysisBase) code that relies on it that won't show up in the CI tests.

Jenkins please retry a build

This merge request affects 3 packages:

• PhysicsAnalysis/AnalysisCommon/ParticleJetTools
• PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging
• PhysicsAnalysis/JetTagging/JetTagTools

Affected files list will not be printed in this case

Adding @duperrin ,@dguest ,@jveatch ,@lidiaz as watchers

added Analysis BTagging Derivation JetEtmiss analysis-review-required master labels

added analysis-review-approved label

CI Result FAILURE (hash 260bfb0b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45005]

added 1 commit

• 8c20b4ed - Remove StandAloneJetBTaggerAlg, BJetBuilder, JetBTaggerTool (none of them are used)

Compare with previous version

Jenkins please retry a build

This merge request affects 3 packages:

• PhysicsAnalysis/AnalysisCommon/ParticleJetTools
• PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging
• PhysicsAnalysis/JetTagging/JetTagTools

Affected files list will not be printed in this case

Adding @duperrin ,@dguest ,@jveatch ,@lidiaz as watchers

changed title from Draft: Remove unused track to jet associator code to Draft: Remove unused btagging wrappers

changed the description

changed title from Draft: Remove unused btagging wrappers to Draft: Remove unused/duplicated btagging code

CI Result SUCCESS (hash 8c20b4ed)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45011]

This looks close @dguest What does the "cloud" icon mean in the ATLAS robot?