Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 176
    • Merge requests 176
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !49603

Remove unused/duplicated btagging code

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dan Guest requested to merge dguest/athena:remove-old-association into master Jan 12, 2022
  • Overview 15
  • Commits 2
  • Pipelines 3
  • Changes 15

This removes an unused track to jet associator, an unused tool that wraps the associator and some other b-tagging tools, and an unused algorithm that calls the the unused tool.

This code isn't used in trigger, reconstruction, or derivations, but it's named very similarly to existing code we do use, and it has a lot of overlapping functionality. It's built around an inheritance hierarchy that is similar to, but separate from, the one we use in our standard code. Basically the standard code we do use is evolution of everything I'm deleting here, but people seem to be maintaining both (probably out of confusion).

This makes figuring out what our code is doing very hard. Better to get rid of it.

@thuffman, @duperrin, this is a draft until I've verified that it doesn't change anything. [this is marked as ready.]

Edited Jan 13, 2022 by Dan Guest
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: remove-old-association