Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 165
    • Merge requests 165
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !49725

Merged
Created Jan 18, 2022 by Chav Chhiv Chau@chchauDeveloper

Fix the NSW sensitve detector tests that were broken due incorrect parameters

  • Overview 3
  • Commits 4
  • Pipelines 1
  • Changes 7

This merge request fixes the main issue in ATLASSIM-4924: broken MicromegasSensitiveDetector_gtest and sTGCSensitiveDetector_gtest tests due to incorrect parameters. Also, MicromegasSensitiveDetector and sTGCSensitiveDetector require the logical volume name to compute the hit identifiers. However, the method G4AtlasTools/DerivedG4SensitiveDetectorTestSetting sets the logical volume name to a dummy string. Therefore, this method is not used.

There are two additional small changes: update namespace in MuonSimEvent/sTgcHitIdHelper and fixing conversion in MuonSimEvent/sTgcSimIdToOfflineId. The sTGC stationName in these two tools are outdated. This should have insignificant effect on the sTGC simulation, since the conversion offline_id to simHit_id is used in only a few places.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: nswGTest