Skip to content
Snippets Groups Projects

MuonReco - Consistent usage of AllBCs TgcPrepData

Merged Johannes Junggeburth requested to merge jojungge/athena:ATLASRECTS-6731 into master
Edited by Johannes Junggeburth

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This merge request affects 4 packages:

    • MuonSpectrometer/MuonReconstruction/MuonRecExample
    • MuonSpectrometer/MuonReconstruction/MuonRecTools/MuonRecHelperTools
    • Reconstruction/MuonIdentification/MuonCombinedConfig
    • Reconstruction/MuonIdentification/MuonCombinedRecExample

    Affected files list will not be printed in this case

    Adding @goetz ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers

  • Will be interested to see if this works, then I can close: !49004 (closed)

    But I fear you will fail in Trigger tests since you have changed the default of MuonEDMPrinterTool, and so now there will be a missing dependency. (I tried to fix this in my MR, but timed out because fixing the trigger stuff was not trivial).

    Edit: to be clearer, in trigger they keep the old behaviour, and so we need to support this. One problem however is that MuonEDMPrinterTool is often used unconfigured.

    Edited by Edward Moyse
  • CI Result FAILURE (hash 46c74ce6)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals
    cmake
    make
    required tests
    optional tests

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    AthGeneration: number of compilation errors 0, warnings 0
    AnalysisBase: number of compilation errors 0, warnings 0
    AthAnalysis: number of compilation errors 0, warnings 0
    DetCommon: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45531]

  • Actually this introduces a huge change in the reference file counter

    
    7,8c7,8
    <       330470  1183723677         583         584         108           9           3          13           0          13          33           0          33
    <       330470  1183724572         518         627         115           7           3           7           0           7          15           0          15
    ---
    >       330470  1183723677         583         584         108           9           4          13           0          13          33           0          33
    >       330470  1183724572         518         627         115           7           4           7           0           7          15           0          15
    11c11
    <       330470  1183727515         408         398          66           3           1           7           0           7          19           0          19
    ---
    >       330470  1183727515         408         398          66           3           0           7           0           7          19           0          19
    16c16
    <       330470  1183729021         390         408          93           7           0          12           0          12          14           0          14
    ---
    >       330470  1183729021         390         408          93           7           1          12           0          12          14           0          14
    19c19
    <       330470  1183731705         735         779         226          16           2          14           0          14          42           0          42
    ---
    >       330470  1183731705         735         779         226          16           3          14           0          14          42           0          42
    24c24
    <       330470  1183733070         431         553         141           9           1          17           0          17          23           0          23
    ---
    >       330470  1183733070         431         553         141           9           2          17           0          17          23           0          23
    33c33
    <       330470  1183736197         453         486          94           7           4           6           0           6          15           0          15
    ---
    >       330470  1183736197         453         486          94           7           5           6           0           6          15           0          15
    59c59
    <       330470  1183746343         492         495          55           5           1           3           0           3          16           0          16
    ---
    >       330470  1183746343         492         495          55           5           0           3           0           3          16           0          16
    66c66
    <       330470  1183748136         663         654         117           9           1          13           0          13          26           0          26
    ---
    >       330470  1183748136         663         654         117           9           2          13           0          13          26           0          26
    68c68
    <       330470  1183748421         460         422          67           8           1           8           0           8          15           0          15
    ---
    >       330470  1183748421         460         422          67           8           2           8           0           8          15           0          15
    79c79
    <       330470  1183755085         482         516         130           8           2          15           0          15          27           0          27
    ---
    >       330470  1183755085         482         516         130           8           3          15           0          15          27           0          27
    81c81
    <       330470  1183756295         367         451          72           8           1           7           0           7          12           0          12
    ---
    >       330470  1183756295         367         451          72           8           2           7           0           7          12           0          12
    97c97
    <       330470  1183762346         487         457         128          11           2          29           0          29          26           0          26
    ---
    >       330470  1183762346         487         457         128          11           4          29           0          29          26           0          26
    100c100
    <       330470  1183764544         400         364          60           4           3           9           0           9          15           0          15
    ---
    >       330470  1183764544         400         364          60           4           2           9           0           9          15           0          15
    108c108
    <       330470  1183768758         656         729         136           8           3          16           0          16          24           0          24
    ---
    >       330470  1183768758         656         729         136           8           2          16           0          16          24           0          24
    137,138c137,138
    <       330470  1183782439         478         550         123          10           2           6           0           6          18           0          18
    <       330470  1183782592         487         574          80           5           1           6           0           6          16           0          16
    ---
    >       330470  1183782439         478         550         123          10           1           6           0           6          18           0          18
    >       330470  1183782592         487         574          80           5           2           6           0           6          16           0          16
    156c156
    <       330470  1183791330         473         700         120           8           3           9           0           9          17           0          17
    ---
    >       330470  1183791330         473         700         120           8           2           9           0           9          17           0          17
    163c163
    <       330470  1183793783         562         522         114           8           4          20           0          20          27           0          27
    ---
    >       330470  1183793783         562         522         114           8           3          20           0          20          27           0          27
    169c169
    <       330470  1183795260         773         649          78           6           1           6           0           6          37           0          37
    ---
    >       330470  1183795260         773         649          78           6           2           6           0           6          37           0          37
    178c178
    <       330470  1183798102         796         915         258          18           5          12           0          12          37           0          37
    ---
    >       330470  1183798102         796         915         258          18           4          12           0          12          37           0          37
    204c204
    <       330470  1183811141         533         498          84           8           3           8           0           8          11           0          11
    ---
    >       330470  1183811141         533         498          84           8           4           8           0           8          11           0          11
    207c207
    <       330470  1183812846         410         468          51           6           0           7           0           7          19           0          19
    ---
    >       330470  1183812846         410         468          51           6           1           7           0           7          19           0          19
    228c228
    <       330470  1183824531         393         363          78           8           4          13           0          13          17           0          17
    ---
    >       330470  1183824531         393         363          78           8           5          13           0          13          17           0          17
    270c270
    <       330470  1183843837         357         374          33           2           1           7           0           7          13           0          13
    ---
    >       330470  1183843837         357         374          33           2           0           7           0           7          13           0          13
    273c273
    <       330470  1183847401         470         461          51           6           1           8           0           8          18           0          18
    ---
    >       330470  1183847401         470         461          51           6           2           8           0           8          18           0          18
    306c306
    <       330470  1183859771         540         599         141          12           4          14           0          14          27           0          27
    ---
    >       330470  1183859771         540         599         141          12           3          14           0          14          27           0          27
    316c316
    <       330470  1183869024         565         537         133          12           3          11           0          11          27           0          27
    ---
    >       330470  1183869024         565         537         133          12           4          11           0          11          27           0          27
    322c322
    <       330470  1183873300         384         372          54           5           1           5           0           5          15           0          15
    ---
    >       330470  1183873300         384         372          54           5           2           5           0           5          15           0          15
    331c331
    <       330470  1183878183         469         389          67           5           1           7           0           7          16           0          16
    ---
    >       330470  1183878183         469         389          67           5           2           7           0           7          16           0          16
    337c337
    <       330470  1183879670         489         525         120           8           1          13           0          13          21           0          21
    ---
    >       330470  1183879670         489         525         120           8           2          13           0          13          21           0          21
    351c351
    <       330470  1183885069         292         240          62           5           3          12           0          12          13           0          13
    ---
    >       330470  1183885069         292         240          62           5           4          12           0          12          13           0          13
    354c354
    <       330470  1183889788         361         471         113           7           3          13           0          13          20           0          20
    ---
    >       330470  1183889788         361         471         113           7           2          13           0          13          20           0          20
    357c357
    <       330470  1183891126         511         511         100          10           5          10           0          10          18           0          18
    ---
    >       330470  1183891126         511         511         100          10           4          10           0          10          18           0          18
    371,372c371,372
    <       330470  1183900525         426         347          79           5           4           9           0           9          18           0          18
    <       330470  1183900622         378         296          53           3           3          10           0          10           8           0           8
    ---
    >       330470  1183900525         426         347          79           5           3           9           0           9          18           0          18
    >       330470  1183900622         378         296          53           3           4          10           0          10           8           0           8
    388c388
    <       330470  1183908744         541         560          56           6           3           3           0           3          19           0          19
    ---
    >       330470  1183908744         541         560          56           6           2           3           0           3          19           0          19
    395c395
    <       330470  1183914114         562         560         104           9           2          13           0          13          26           0          26
    ---
    >       330470  1183914114         562         560         104           9           3          13           0          13          26           0          26
    409c409
    <       330470  1183924996         367         385          36           5           4           2           0           2           7           0           7
    ---
    >       330470  1183924996         367         385          36           5           5           2           0           2           7           0           7
    424c424
    <       330470  1183935176         505         635         103           9           1           8           0           8          21           0          21
    ---
    >       330470  1183935176         505         635         103           9           0           8           0           8          21           0          21
    434c434
    <       330470  1183941479         270         333           8           1           0           2           0           2           6           0           6
    ---
    >       330470  1183941479         270         333           8           1           1           2           0           2           6           0           6
    441c441
    <       330470  1183952907         561         642          55           4           3           9           0           9          17           0          17
    ---
    >       330470  1183952907         561         642          55           4           2           9           0           9          17           0          17
    453c453
    <       330470  1183963195         522         567         112          12           1          13           0          13          20           0          20
    ---
    >       330470  1183963195         522         567         112          12           2          13           0          13          20           0          20
    458c458
    <       330470  1183973235         544         533          64           5           1           5           0           5          17           0          17
    ---
    >       330470  1183973235         544         533          64           5           2           5           0           5          17           0          17
    471c471
    <       330470  1183991258         380         393          36           6           0           1           0           1          13           0          13
    ---
    >       330470  1183991258         380         393          36           6           1           1           0           1          13           0          13
    474c474
    <       330470  1183995076         239         205           9           1           2           1           0           1           5           0           5
    ---
    >       330470  1183995076         239         205           9           1           1           1           0           1           5           0           5
    490c490
    <       330470  1184020401         563         454          74           8           4           7           0           7          28           0          28
    ---
    >       330470  1184020401         563         454          74           8           3           7           0           7          28           0          28
    496c496
    <       330470  1184045730         361         462          66           7           1           5           0           5          14           0          14
    ---
    >       330470  1184045730         361         462          66           7           2           5           0           5          14           0          14
    INFO     -----------------------------------------------------
    
    INFO     -----------------------------------------------------
    INFO     ---------------------- Summary ----------------------
    ERROR    ALL TESTS: FAILED (10)

    It seems plausible to me as we include now all TGC hits. Asking @wleight for his opinion

  • Hi @jojungge ,

    Yeah, that would be my suspicion too. Is it just that the logic is backwards here:

    TgcPrepDataContainer = 'TGC_MeasurementsAllBCs' if not muonRecFlags.useTGCPriorNextBC else 'TGC_Measurements')

    Shouldn't it be "if", not "if not", since you set useTGCPriorNextBC to be false by default?

    thanks,

    will

  • Hi,

    this way, the AllBCs containers a loaded. I had to change the default value because it is somewhere overwritten from True to False

  • Ok, maybe I misunderstood, so the goal is that the AllBC containers should be loaded by default?

  • Setting review-user-action-required until discussions about count reference changes are resolved.

    Jakub (L1 shifter)

  • Try out what happens with public EDM Printers

  • Jenkins please retry a build

  • This merge request affects 4 packages:

    • MuonSpectrometer/MuonReconstruction/MuonRecExample
    • MuonSpectrometer/MuonReconstruction/MuonRecTools/MuonRecHelperTools
    • Reconstruction/MuonIdentification/MuonCombinedConfig
    • Reconstruction/MuonIdentification/MuonCombinedRecExample

    Affected files list will not be printed in this case

    Adding @goetz ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers

  • CI Result FAILURE (hash 46c74ce6)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals
    cmake
    make
    required tests
    optional tests

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    AthGeneration: number of compilation errors 0, warnings 0
    AnalysisBase: number of compilation errors 0, warnings 0
    AthAnalysis: number of compilation errors 0, warnings 0
    DetCommon: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45712]

  • The unit test failures are unrelated, but the other test failures seem to have something to do with this update, see e.g. log for Trigger_athena_data-test:

    AvalancheSchedulerSvc                                                     20     0   ERROR *** Stall detected in slot 0! ***
    AvalancheSchedulerSvc                                                     20     0   ERROR Event 20 on slot 0 failed
      TrigMuonCombinedAlg_FS (261), w/ decision: UNDEFINED(-1), in state: CONTROLREADY
      missing data:  ( 'Muon::TgcPrepDataContainer' , 'StoreGateSvc+TGC_MeasurementsAllBCs' ) 
      required by tool: TrigMuonCombinedAlg_FS.MuonCombinedTool
      can be produced by alg(s): ( TgcRdoToTgcPrepData_EFMuMSReco_FSRoIs in state: INITIAL ) ( TgcRdoToTgcPrepData_EFMuMSReco_RoIRoIs in state: INITIAL ) ( TgcRdoToTgcPrepData_L2MuFastRecoRoIs in state: INITIAL ) 
      TrigMuonCreatorAlgCB_FS (262), w/ decision: UNDEFINED(-1), in state: CONTROLREADY
      missing data:  ( 'MuonCombined::InDetCandidateToTagMap' , 'StoreGateSvc+muidcoTagMap' ) 
      can be produced by alg(s): ( TrigMuonCombinedAlg_FS in state: CONTROLREADY ) ( TrigMuonCombinedAlg_RoI in state: INITIAL ) 
      missing data:  ( 'Muon::TgcPrepDataContainer' , 'StoreGateSvc+TGC_MeasurementsAllBCs' ) 
      required by tool: TrigMuonCreatorAlgCB_FS.MuonCreatorTool
      can be produced by alg(s): ( TgcRdoToTgcPrepData_EFMuMSReco_FSRoIs in state: INITIAL ) ( TgcRdoToTgcPrepData_EFMuMSReco_RoIRoIs in state: INITIAL ) ( TgcRdoToTgcPrepData_L2MuFastRecoRoIs in state: INITIAL ) 
      TrigMuonCombinedAlg_FS (261), w/ decision: UNDEFINED(-1), in state: CONTROLREADY
      missing data:  ( 'Muon::TgcPrepDataContainer' , 'StoreGateSvc+TGC_MeasurementsAllBCs' ) 
      required by tool: TrigMuonCombinedAlg_FS.MuonCombinedTool
      can be produced by alg(s): ( TgcRdoToTgcPrepData_EFMuMSReco_FSRoIs in state: INITIAL ) ( TgcRdoToTgcPrepData_EFMuMSReco_RoIRoIs in state: INITIAL ) ( TgcRdoToTgcPrepData_L2MuFastRecoRoIs in state: INITIAL ) 
      TrigMuonCreatorAlgCB_FS (262), w/ decision: UNDEFINED(-1), in state: CONTROLREADY
      missing data:  ( 'MuonCombined::InDetCandidateToTagMap' , 'StoreGateSvc+muidcoTagMap' ) 
      can be produced by alg(s): ( TrigMuonCombinedAlg_FS in state: CONTROLREADY ) ( TrigMuonCombinedAlg_RoI in state: INITIAL ) 
      missing data:  ( 'Muon::TgcPrepDataContainer' , 'StoreGateSvc+TGC_MeasurementsAllBCs' ) 
      required by tool: TrigMuonCreatorAlgCB_FS.MuonCreatorTool
      can be produced by alg(s): ( TgcRdoToTgcPrepData_EFMuMSReco_FSRoIs in state: INITIAL ) ( TgcRdoToTgcPrepData_EFMuMSReco_RoIRoIs in state: INITIAL ) ( TgcRdoToTgcPrepData_L2MuFastRecoRoIs in state: INITIAL ) 
    AthenaHiveEventLoopMgr                                                               FATAL Failed event detected on s: 0  e: 20 w/ fail mode: AlgStall
    Py:ComponentAccumulator   ERROR Failure running application

    Jakub (L1 shifter)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading