Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 120
    • Merge requests 120
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !54280

update of muonSelectionTool for r22 and run3 (second try)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Marco Vanadia requested to merge mvanadia/athena:master-mvdevbranch2 into 22.0 Jun 15, 2022
  • Overview 16
  • Commits 15
  • Pipelines 5
  • Changes 5

ok I need a new MR because I made a mess with the branch I was using for !52702 (closed)

wrt to the previous MR I added an expert option to the tool to avoid crashes when run2/run3 geometry is not properly configured, allowing for understanding it on the fly. Not super-nice but we need this in asap.

CC @jojungge @gabarone @yoyamagu @dcieri

I copy here for reference the description from the previous MR.

This MR will

  • adds a IsRun3Geo property to the tool (default false). There is a sanity check that the runnumber is actually compatible with the chosen option.
  • adds ExcludeNSWFromPrecisionLayers property for the tool (default true). If true and in run3, it reduces the numberOfPrecisionLayers of the muon by 1 for muons with |eta|>1.05 with at least one hit in the inner station, which of course affects which muons pass the cuts on this quantity for the different WPs.
  • for run3, only allows usage of Medium/Loose/HighPt WPs if not in expert mode. HighPt will only accept muons in the barrel, if not in expert mode.
  • rejects SA and SAF muons for run3 if not in expert mode.
  • disables ad-hoc code for CSCs for run3.
  • temporary comments out BMG veto for highPt muons, since this regions should have better alignment in r22 (to be tested)
  • adds some WARNINGs in the first event in case there are problems in reading the randomRunNumber from the PRW tool
  • adds a couple of fatal + relative exceptions in cases the data period cannot be correctly identified
  • updates the MuonSelectorToolsTester to identify if running on run2 or run3 and configures the tools accordingly
Edited Jun 15, 2022 by Marco Vanadia
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master-mvdevbranch2