Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 179
    • Merge requests 179
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !56229

SV1 vertex reco clean up

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Thomas Strebler requested to merge tstreble/athena:SV1_Run4 into 22.0 Aug 25, 2022
  • Overview 14
  • Commits 4
  • Pipelines 3
  • Changes 6

This MR follows the observation that SV1 vertices do not seem to be reconstructed for forward jets with the Upgrade configuration. This appears to be related to the new InDetTrkInJetType introduced in master and not yet present in previous studies in 21.9.

Consequently, this MR

  • updates the CA config of the InDetVKalVxInJetTool package, collecting the various pieces existing in different places, and disable the SCT hit requirement used in the InDetTrkInJetType tool for Upgrade configs
  • provides a general code-style clean up of BTagVrtSec, in view of the introduction of an option to disable the InDetTrkInJetType tool in a future MR (to keep review easier)

This was checked to leave the output of the DAOD_PHYSVAL binary identical for the Run 3 configuration.

FYI @kostyuk @khanov @duperrin @thuffman

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: SV1_Run4