SV1 vertex reco clean up

Thomas Streblerrequested to merge
tstreble/athena:SV1_Run4 into 22.0

This MR follows the observation that SV1 vertices do not seem to be reconstructed for forward jets with the Upgrade configuration. This appears to be related to the new InDetTrkInJetType introduced in master and not yet present in previous studies in 21.9.

Consequently, this MR

  • updates the CA config of the InDetVKalVxInJetTool package, collecting the various pieces existing in different places, and disable the SCT hit requirement used in the InDetTrkInJetType tool for Upgrade configs
  • provides a general code-style clean up of BTagVrtSec, in view of the introduction of an option to disable the InDetTrkInJetType tool in a future MR (to keep review easier)

This was checked to leave the output of the DAOD_PHYSVAL binary identical for the Run 3 configuration.

FYI @kostyuk @khanov @duperrin @thuffman

Merge request reports