Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 181
    • Merge requests 181
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !56298

Fix B-Line parameter access of the NSW prepdata

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Johannes Junggeburth requested to merge jojungge/athena:ATLASRECTS-7220 into 22.0 Aug 28, 2022
  • Overview 9
  • Commits 5
  • Pipelines 0
  • Changes 7

Hi everybody,

in ATLASRECTS-7220, an irreproducibility of the muon reconstruction in the unassociated segment container was reported. The culprit was an improper parsing of the BLine parameters to the ReadoutGeometry. The address of the local BLineParinstance was parsed to the NSW detector elements instead of the instance that's cached by the MuonDetectorElement. Consequently, the memory was no longer valid when the parameters were applied and the read numbers could give very nuts results. For instance, the wedge can be inside the inner detector

grafik

or at the other end of the universe.

grafik

This MR fixes primarily the B-line parameter access. The rest are initialization fixes.

Tagging @pberta, @jmaurer @elmsheus, @nstyles to make them aware of this urgent bugfix.

A yes... I forgot, the trigger is not affected because the as-built is not loaded there.

Closes ATLASRECTS-7220

grafik

Edited Aug 28, 2022 by Johannes Junggeburth
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ATLASRECTS-7220