Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 156
    • Merge requests 156
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !56518

Draft: Adding Photon Isolation to TLA EDM + Backup Photon+Jets

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Marco Montella requested to merge mmontell/athena:TLA_PhotonThresholds into 22.0 Sep 05, 2022
  • Overview 5
  • Commits 3
  • Pipelines 0
  • Changes 2

This MR adds a number of backup triggers for Photon+Jets TLA in order to have a flexible data-taking strategy that can quickly adapt to all scenarios involving the LAr ROS access rate upon machine restart.

The new chains are:

HLT_g40_tight_3j25_pf_ftf_PhysicsTLA_L1EM22VHI
HLT_g45_tight_3j25_pf_ftf_PhysicsTLA_L1EM22VHI
HLT_g60_tight_3j25_pf_ftf_PhysicsTLA_L1EM22VHI
HLT_g60_tight_3j25_pf_ftf_PhysicsTLA_L1EM22VHI

A second batch of chains are added which explicitly require the isolation calculation:

HLT_g35_tight_icaloloose_3j25_pf_ftf_PhysicsTLA_L1EM22VHI
HLT_g45_tight_icaloloose_3j25_pf_ftf_PhysicsTLA_L1EM22VHI
HLT_g60_tight_icaloloose_3j25_pf_ftf_PhysicsTLA_L1EM22VHI

Furthermore, this MR adds the photon isolation variables to the TLA EDM by means of:

PhToKeep = ['topoetcone20', 'topoetcone40', 'etcone20']
PhVars = '.'.join(PhToKeep)
('xAOD::PhotonAuxContainer#HLT_egamma_Photons_TLAAux.'+PhVars,                             'BS PhysicsTLA JetPEBPhysicsTLA ESD', 'Egamma'),

CURRENT STATUS:

A single-chain test run on a icaloloose chain works as intended. A test run with the full menu (or even a two-chain run with an iso and a non-iso TLA chains) runs into the following error message:

2022-09-05 17:34:08,374  Py:TriggerMenuMT:MenuComponents      ERROR ComboMaker for Alg:ComboHypo_Step9_merged2_TLAStep_merged_EmptyJetMETAlign3_Photon_MainStep_jet_a4_pf_em_subresjesgscIS_ftf with addChain for:HLT_g45_tight_icaloloose_3j25_pf_ftf_PhysicsTLA_L1EM22VHI Chain multiplicity:(1, 3) Per leg input collection index:().
2022-09-05 17:34:08,374  Py:TriggerMenuMT:MenuComponents      ERROR The size of the multiplicies vector must be the same size as the per leg input collection vector.
2022-09-05 17:34:08,374  Py:TriggerMenuMT:MenuComponents      ERROR The ComboHypo needs to know which input DecisionContainers contain the DecisionObjects to be used for each leg.
2022-09-05 17:34:08,374  Py:TriggerMenuMT:MenuComponents      ERROR Check why ComboMaker.addInput(...) was not called exactly once per leg.

Tagging @tamartin for expert support.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: TLA_PhotonThresholds